Adding special character caveat to PG DBM doc #23095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customers often get password validation failed errors from our postgres integration/DBM which is often caused by special characters. The line I added is copied directly from the MySQL version of this doc: https://github.com/DataDog/documentation/edit/master/content/en/database_monitoring/setup_mysql/rds.md/
lu-zhengda
reviewed
May 9, 2024
| @@ -248,6 +248,8 @@ Installing the Datadog Agent also installs the Postgres check which is required | |||
| {{% /tab %}} | |||
| {{< /tabs >}} | |||
|
|
|||
| **Note**: Wrap your password in single quotes in case a special character is present. | |||
There was a problem hiding this comment.
shall we add this note to all deployment types?
aliciascott
requested changes
May 10, 2024
There was a problem hiding this comment.
Hi @JakeYankovich this looks good, just a minor suggestion and then looks like product has requested to add this to all the deployment types. Please request re-review when updated, thanks!
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
aliciascott
requested changes
May 10, 2024
| @@ -248,7 +248,7 @@ Installing the Datadog Agent also installs the Postgres check which is required | |||
| {{% /tab %}} | |||
| {{< /tabs >}} | |||
|
|
|||
| **Note**: Wrap your password in single quotes in case a special character is present. | |||
| **Note**: Wrap your password in single quotes if special character is present. | |||
There was a problem hiding this comment.
Suggested change
| **Note**: Wrap your password in single quotes if special character is present. | |
| **Note**: Wrap your password in single quotes if a special character is present. |
This was my fault !! Can you add the "a" and then I'll approve :)
|
Hi @JakeYankovich just making sure you saw there was one more update to fix and then I'll get this merged, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers often get password validation failed errors from our postgres integration/DBM which is often caused by special characters. The line I added is copied directly from the MySQL version of this doc: https://github.com/DataDog/documentation/edit/master/content/en/database_monitoring/setup_mysql/rds.md/
What does this PR do? What is the motivation?
I have had about a half-dozen postgres customers running into issues due to special characters in their passwords
Merge instructions
Additional notes