Add direct link to auto discovery docs in mysql/postgres aurora setup #23110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
aliciascott
requested changes
May 10, 2024
There was a problem hiding this comment.
Hi @jmeunier28 this looks good, just some small suggestions, please request re-review once updated, thanks!
|
@aliciascott thanks! |
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
aliciascott
approved these changes
May 10, 2024
There was a problem hiding this comment.
Hi @jmeunier28 I forgot to mention that the links that are within tabs need to be placed within the tab section, I just pushed up a fix to correct that, let me know if this is ready to be merged as well?
|
Ah sorry about that! Yes @aliciascott please merge whenever you get a chance! Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Adds direct note in setup docs on how to use the new auto discovery feature in the agent
Merge instructions
Additional notes