Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ANRs in RUM mobile android SDKs #23118

Merged
merged 7 commits into from May 17, 2024

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented May 10, 2024

What does this PR do? What is the motivation?

  • Adds information on fatal and non-fatal ANR reporting in Datadog, including how to change the default setting for non-fatal ANR reporting

Merge instructions

  • Please merge after reviewing

Additional notes

@rtrieu rtrieu requested a review from a team as a code owner May 10, 2024 20:07
@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label May 10, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@MaelNamNam MaelNamNam self-requested a review May 14, 2024 13:36
@github-actions github-actions bot added the Images Images are added/removed with this PR label May 15, 2024
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 15, 2024
@rtrieu rtrieu changed the title Report ANRs in RUM mobile android SDks Report ANRs in RUM mobile android SDKs May 15, 2024
@MaelNamNam MaelNamNam requested a review from 0xnm May 15, 2024 19:51
Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I left a bunch of comments but very minor stuff, thanks a lot!

@urseberry urseberry self-assigned this May 15, 2024
Copy link
Contributor

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with suggestions from @MaelNamNam. For the rest it looks good to me.

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few small suggestions.

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@rtrieu rtrieu merged commit 27838bb into master May 17, 2024
14 checks passed
@rtrieu rtrieu deleted the rtrieu/docs-7784-mobile-rum-report-anrs branch May 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants