Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rum] DOCS-7809 Add supported platforms versions ios #23120

Merged
merged 13 commits into from May 16, 2024
Merged

[rum] DOCS-7809 Add supported platforms versions ios #23120

merged 13 commits into from May 16, 2024
+170 −28

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented May 10, 2024

What does this PR do? What is the motivation?

  • Adds an exhaustive list of supported versions and platforms for the RUM iOS SDK

Merge instructions

  • Please merge after reviewing

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label May 10, 2024
@rtrieu rtrieu requested a review from a team as a code owner May 10, 2024 21:03
@rtrieu rtrieu requested a review from MaelNamNam May 10, 2024 21:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@MaelNamNam
Copy link
Contributor

Commented here

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 14, 2024
@rtrieu rtrieu requested a review from a team as a code owner May 15, 2024 14:10
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 15, 2024
MaelNamNam
MaelNamNam requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few links to change, but apart from this it's looking good, thank you very much!

content/en/real_user_monitoring/mobile_and_tv_monitoring/setup/ios.md Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/supported_versions/ios.md Outdated Show resolved Hide resolved
@urseberry urseberry self-assigned this May 15, 2024
@rtrieu rtrieu requested a review from MaelNamNam May 15, 2024 20:31
MaelNamNam
MaelNamNam approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtrieu @urseberry
Apply suggestions from code review
8ebc24b 
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@rtrieu rtrieu requested a review from urseberry May 16, 2024 13:53
@rtrieu rtrieu merged commit fdd6ce8 into master May 16, 2024
12 of 13 checks passed
@rtrieu rtrieu deleted the rtrieu/docs-7809-add-supported-platforms-versions-ios branch May 16, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelNamNam MaelNamNam MaelNamNam approved these changes

@urseberry urseberry urseberry approved these changes

@maciejburda maciejburda Awaiting requested review from maciejburda

Assignees

@urseberry urseberry

Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtrieu @MaelNamNam @urseberry