Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention to DD_TRACE_OTEL_ENABLED #23123

Merged
merged 7 commits into from May 22, 2024
Merged

Conversation

julianocosta89
Copy link
Contributor

@julianocosta89 julianocosta89 commented May 10, 2024

What does this PR do? What is the motivation?

DD_TRACE_OTEL_ENABLED=true
is mentioned under https://docs.datadoghq.com/tracing/trace_collection/custom_instrumentation/java/otel/#setup and should also be called out under https://docs.datadoghq.com/tracing/trace_collection/library_config/java.

Merge instructions

  • Please merge after reviewing

@julianocosta89 julianocosta89 requested a review from a team as a code owner May 10, 2024 22:20
@mcculls
Copy link
Contributor

mcculls commented May 11, 2024

We should remove this from the experimental section at the same time, because DD_TRACE_OTEL_ENABLED replaces it:

dd.integration.opentelemetry.experimental.enabled : Environment Variable: DD_INTEGRATION_OPENTELEMETRY_EXPERIMENTAL_ENABLED
Default: false
Enables experimental OpenTelemetry features. When you enable this setting, you can use the OpenTelemetry tracing API backed by the Datadog Trace Agent.
Available since version 1.10.0

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but otherwise looks good. Thanks!

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drichards-87 drichards-87 merged commit 759984a into master May 22, 2024
9 of 10 checks passed
@drichards-87 drichards-87 deleted the julianocosta89-patch-1 branch May 22, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants