Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cilium] Add support for v1.14 metrics #17447

Merged

Conversation

jaredledvina
Copy link
Member

@jaredledvina jaredledvina commented Apr 24, 2024

What does this PR do?

This PR updates the cilium integration to include support for new and changes metrics in the v1.14 release.

Motivation

Natively supporting the v1.14 metrics means folks get all of the metrics out of the box without needed to run the openmetrics integration.

Additional Notes

This PR still needs to have updated tests. It's also unclear how to handle prometheus 'HistogramVec' type metrics within the integration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
@jaredledvina jaredledvina force-pushed the jared.ledvina/cilium-1.14-metrics branch from f100e19 to a412dc0 Compare April 24, 2024 21:37
Copy link

github-actions bot commented Apr 24, 2024

Test Results

 8 files   8 suites   15s ⏱️
 8 tests  4 ✅  4 💤 0 ❌
46 runs  12 ✅ 34 💤 0 ❌

Results for commit 2c6e044.

♻️ This comment has been updated with latest results.

Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.55%. Comparing base (2a6ec26) to head (2c6e044).
Report is 44 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory ?
ambari ?
arangodb ?
avi_vantage ?
cilium 78.20% <80.00%> (?)
cisco_aci ?
cloudera ?
crio ?
datadog_cluster_agent ?
dcgm ?
ecs_fargate ?
external_dns ?
ibm_db2 ?
karpenter ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kyototycoon ?
linux_proc_extras ?
mcache ?
nginx ?
nvidia_triton ?
pgbouncer ?
silk ?
snowflake ?
strimzi ?
system_swap ?
temporal ?
twistlock ?
varnish ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@jaredledvina jaredledvina marked this pull request as ready for review May 8, 2024 14:36
@jaredledvina jaredledvina requested a review from a team as a code owner May 8, 2024 14:36
Co-authored-by: Kyle Neale <kyle.a.neale@gmail.com>
@Kyle-Neale Kyle-Neale merged commit d12b0b4 into DataDog:master May 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants