Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new integration template #17474

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Apr 29, 2024

What does this PR do?

Updates template for creating a new integration.

Motivation

Incorporating feedback from partners while staying compatible with integrations-core practices.

Meant to supercede #17317

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

emarsha94 and others added 19 commits April 29, 2024 10:56
Updating to include more info/examples
…ation/check/{check_name}/CHANGELOG.md

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
…ation/check/{check_name}/README.md

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
…ation/check/{check_name}/manifest.json

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
…ation/check/{check_name}/manifest.json

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
…ation/check/{check_name}/manifest.json

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
…ation/marketplace/IMAGES_README.md

Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
- display on public website
- media
@iliakur iliakur requested a review from emarsha94 April 29, 2024 08:59
@iliakur iliakur changed the title Update new integration scaffolding Update new integration template Apr 29, 2024
Copy link

@dkirov-dd dkirov-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

Test Results

  4 files    4 suites   3m 39s ⏱️
391 tests 390 ✅  0 💤 1 ❌
882 runs  847 ✅ 33 💤 2 ❌

For more details on these failures, see this check.

Results for commit e8ae1f2.

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

"title": "{integration_name}",
"media": [],
"media": {media},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it will link to the outline that's included in the assets/dashboard manifest? ex:
"media": [
{
"media_type": "image",
"caption": "FILL IN Image 1 caption",
"image_url": ""
},
{
"media_type": "image",
"caption": "FILL IN Image 2 caption",
"image_url": ""
},
{
"media_type": "image",
"caption": "FILL IN Image 3 caption",
"image_url": ""
}

"tile": {{
"overview": "README.md#Overview",
"configuration": "README.md#Setup",
"support": "README.md#Support",
"changelog": "CHANGELOG.md",
"description": "",
"description": "<FILL IN>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace with: "<FILL IN - A brief description of what this offering provides>"

"tile": {{
"overview": "README.md#Overview",
"configuration": "README.md#Setup",
"support": "README.md#Support",
"changelog": "CHANGELOG.md",
"description": "",
"description": "<FILL IN>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace with: "<FILL IN - A brief description of what this offering provides>"

]
}},
"assets": {{
"dashboards": {{}},
"dashboards": {{
"<FILL IN dashboard short_name>": "assets/dashboards/<FILL IN>.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<FILL IN dashboard short_name>": "assets/dashboards/<FILL IN>.json"
"<FILL IN dashboard short_name ex: integration name overview>": "assets/dashboards/<FILL IN>.json"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants