Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token auth for teamcity integration #17478

Merged

Conversation

gbx-andrew-schneider
Copy link
Contributor

What does this PR do?

Skip adding auth type to URL if using token auth.

Motivation

As currently implemented, the teamcity integration automatically adds either 'guestAuth' or 'httpAuth' to the URL, and doesn't offer any mechanism to skip adding them. However, these paths don't work when using token auth, making it impossible to use this integration with a TeamCity server that doesn't allow either anonymous access or basic auth.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Apr 29, 2024

Test Results

  6 files   6 suites   37s ⏱️
 40 tests 40 ✅  0 💤 0 ❌
132 runs  52 ✅ 80 💤 0 ❌

Results for commit b66690b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.53%. Comparing base (2a6ec26) to head (b66690b).
Report is 56 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory ?
activemq_xml ?
aerospike ?
airflow ?
amazon_msk ?
ambari ?
arangodb ?
avi_vantage ?
azure_iot_edge ?
ceph ?
cisco_aci ?
citrix_hypervisor ?
clickhouse ?
cloudera ?
cockroachdb ?
couch ?
couchbase ?
crio ?
datadog_checks_base ?
datadog_checks_downloader ?
datadog_cluster_agent ?
dcgm ?
ddev ?
dns_check ?
dotnetclr ?
druid ?
ecs_fargate ?
elastic ?
envoy ?
exchange_server ?
external_dns ?
gearmand ?
gitlab_runner ?
glusterfs ?
gunicorn ?
haproxy ?
harbor ?
http_check ?
ibm_db2 ?
ibm_was ?
iis ?
karpenter ?
kong ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubernetes_state ?
kyototycoon ?
linux_proc_extras ?
mapr ?
marathon ?
marklogic ?
mcache ?
mesos_slave ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
nvidia_triton ?
openmetrics ?
oracle ?
pdh_check ?
pgbouncer ?
php_fpm ?
postfix ?
postgres ?
process ?
prometheus ?
rabbitmq ?
ray ?
redisdb ?
riakcs ?
sap_hana ?
scylla ?
silk ?
snmp ?
snowflake ?
sonarqube ?
spark ?
sqlserver ?
ssh_check ?
statsd ?
strimzi ?
system_core ?
system_swap ?
tcp_check ?
teamcity 88.53% <72.72%> (+18.59%) ⬆️
tekton ?
temporal ?
twemproxy ?
twistlock ?
varnish ?
vault ?
vertica ?
voltdb ?
vsphere ?
weaviate ?
win32_event_log ?
windows_performance_counters ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 merged commit a026087 into DataDog:master May 15, 2024
32 checks passed
@gbx-andrew-schneider gbx-andrew-schneider deleted the fix/teamcity-auth-tokens branch May 15, 2024 14:35
@Kyle-Neale Kyle-Neale mentioned this pull request May 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants