Collect nginx ingress controller metrics related to request and response sizes #17509
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 tests 1 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 6089209. |
…nse sizes These two metrics are described in the ingress-nginx documentation here: <https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/monitoring.md>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds two histogram metrics to the nginx ingress controller integration: request size and response size, in bytes.
Motivation
I find them pretty useful to get an idea of the distribution of sizes of responses for API endpoints. I also added request size mostly for symmetry, but I don't think it will be as useful (for me at least).
Additional Notes
These two metrics are described in the ingress-nginx documentation here:
https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/monitoring.md
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged