Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Batch on ECS Fargate docs #17534

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented May 7, 2024

What does this PR do?

Add documentation for AWS Batch on ECS Fargate

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@fanny-jiang fanny-jiang changed the title Add AWS Batch for ECS Fargate docs Add AWS Batch on ECS Fargate docs May 7, 2024
cswatt
cswatt previously approved these changes May 10, 2024
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I pushed some formatting edits, moved some things around. I also added a link to https://docs.datadoghq.com/resources/json/datadog-agent-aws-batch-ecs-fargate.json (which does not yet exist). Ensure that this file gets added in the documentation repo before merging this PR.

I also created a preview branch: https://docs-staging.datadoghq.com/cswatt/preview_aws_batch/integrations/ecs_fargate
If you make any further changes to this PR and would like to preview them in staging, let me know and I'll rerun the preview job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants