[PLINT-389] Merge new ironic metrics into master #17541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding metric openstack.ironic.node.portgroup.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * undoing change to conf.yaml.example Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * clarified portgroup metric name by prepending portgroup_ Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
* adding metric openstack.ironic.port.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * lint Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * standardizing metric name Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing redundant loop Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * Update openstack_controller/datadog_checks/openstack_controller/components/bare_metal.py Co-authored-by: José Manuel Almaza Ramiro <josemanuel.almaza@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> Co-authored-by: José Manuel Almaza Ramiro <josemanuel.almaza@datadoghq.com>
* adding metric openstack.ironic.volume.connector.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding metric openstack.ironic.volume.target.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * updating instance.py Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing COUNT from metrics in get_metrics_and_tags Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * removing duplicate IRONIC_VOLUME_PREFIX Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
* adding metric openstack.ironic.driver.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> * adding metric openstack.ironic.allocation.count Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com> --------- Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Test Results 5 files 5 suites 2m 43s ⏱️ Results for commit 122b53a. ♻️ This comment has been updated with latest results. |
jose-manuel-almaza
previously approved these changes
May 8, 2024
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
rahulkaukuntla
changed the title
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
…rsion is too low Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
sarah-witt
reviewed
May 10, 2024
openstack_controller/datadog_checks/openstack_controller/api/api_rest.py
Show resolved
Hide resolved
openstack_controller/datadog_checks/openstack_controller/api/api_rest.py
Show resolved
Hide resolved
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
Signed-off-by: rahulkaukuntla <rahul.kaukuntla@datadoghq.com>
sarah-witt
approved these changes
May 10, 2024
jose-manuel-almaza
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge new ironic metrics into master
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged