[datadog_cloud_configuration_rule] Implemented resource to manage cloud_configuration rules #1677
+1,101
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
from
385408d to
f81020b
Compare
symphony-elias
changed the title
symphony-elias
commented
Dec 20, 2022
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
from
f81020b to
0c3a4a6
Compare
estherk15
previously approved these changes
Dec 20, 2022
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
from
770cac2 to
8ca0cbf
Compare
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
from
8ca0cbf to
4f08fb3
Compare
estherk15
previously approved these changes
Dec 21, 2022
skarimo
reviewed
Dec 27, 2022
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
2 times, most recently
from
4bfc195 to
3d8dbf5
Compare
symphony-elias
force-pushed
the
elias.croze/sec-6093
branch
from
3d8dbf5 to
256b83c
Compare
Bit-Doctor
previously approved these changes
Jan 2, 2023
| Optional: true, | ||
| Description: "Related resource types to be checked by the rule. Defaults to empty list.", | ||
| MinItems: 0, | ||
| MaxItems: 9, |
There was a problem hiding this comment.
Did we decided to go with max 9 in the end? I thought it was 5 last time I followed the conversation.
There was a problem hiding this comment.
The code in the backend limits to 10 resource types (main resource type + related resource types): https://github.com/DataDog/logs-backend/blob/prod/domains/cloud-security-platform/apps/security-monitoring-api/src/main/java/com/dd/logs/api/rule_engine/validators/compliance/CloudConfigurationRuleValidator.java#L209
Co-authored-by: Jonathan Machado <jonathan.machado@outlook.com>
Bit-Doctor
approved these changes
Jan 3, 2023
skarimo
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented new resource
datadog_cloud_configuration_ruleto manage security monitoring rules of typecloud_configuration.Jira card: https://datadoghq.atlassian.net/browse/SEC-6093