[datadog_integration_gcp] Support enabling the CSPM integration #1748
+82
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophetd
commented
Feb 1, 2023
christophetd
force-pushed
the
gcp-integration-support-enabling-cspm
branch
from
ae6fa51 to
9741adc
Compare
christophetd
changed the title
|
(closes #1743) |
|
👋🏼 Eager to get this PR reviewed, and will get it merged once the next release of the Go SDK lands next week |
skarimo
previously approved these changes
Feb 1, 2023
therve
previously approved these changes
Feb 1, 2023
|
Thanks for the review! Will wait for the Go SDK release next week, update the go.mod and then merge it |
rtrieu
previously approved these changes
Feb 1, 2023
christophetd
force-pushed
the
gcp-integration-support-enabling-cspm
branch
from
d5b8851 to
56d2819
Compare
…on_enabled' attribute (closes #1743)
christophetd
force-pushed
the
gcp-integration-support-enabling-cspm
branch
from
56d2819 to
bcea13c
Compare
|
Now rebased on latest |
christophetd
force-pushed
the
gcp-integration-support-enabling-cspm
branch
from
6b52370 to
d73ccef
Compare
therve
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: While the API does support it, it's currently not possible to enable the GCP CSPM through Terraform. The AWS integration resource does have support for it: https://registry.terraform.io/providers/DataDog/datadog/latest/docs/resources/integration_aws#cspm_resource_collection_enabled