[CONTINT-3529] Add basic ecs fargate windows app #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliDatadog
changed the title
AliDatadog
force-pushed
the
ali/ecs-fargate-windows
branch
from
ecf3e00
to
a4807ec
Compare
AliDatadog
force-pushed
the
ali/ecs-fargate-windows
branch
from
a4807ec
to
078b9d2
Compare
AliDatadog
force-pushed
the
ali/ecs-fargate-windows
branch
from
46ededa
to
7289cfe
Compare
AliDatadog
force-pushed
the
ali/ecs-fargate-windows
branch
from
ada285c
to
4bbe63c
Compare
vboulineau
reviewed
Mar 28, 2024
|
|
||
| opts = append(opts, pulumi.Parent(EcsFargateComponent)) | ||
|
|
||
| nlb, err := lb.NewNetworkLoadBalancer(e.Ctx, namer.ResourceName("lb"), &lb.NetworkLoadBalancerArgs{ |
There was a problem hiding this comment.
Why do you need an LB?
There was a problem hiding this comment.
I was thinking of adding a query app too in another PR.
There was a problem hiding this comment.
I removed the load balancer so we can add it in another PR if needed
AliDatadog
force-pushed
the
ali/ecs-fargate-windows
branch
from
a8af4e9
to
d84b06b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a basic ecs fargate windows application.
Which scenarios this will impact?
aws/ecs
Example: https://dddev.datadoghq.com/notebook/7776845/ali-windows-ecs?cell-31ekfdth-live=false&cell-31ekfdth-range=50606&cell-31ekfdth-start=1711630015394&cell-v7z96u34-live=false&cell-v7z96u34-range=1823936&cell-v7z96u34-start=1711628242064
Motivation
We would like to easily setup an ecs fargate windows setup.
Additional Notes