[EKS] Add nginx and redis fargate workloads #757
Conversation
| Type: pulumi.String("AverageValue"), | ||
| AverageValue: pulumi.String("10"), |
There was a problem hiding this comment.
In fact, I recently discovered (See #721) that using AverageValue was a mistake because the query that is done is already computing an average:
avg:nginx.net.request_per_s{kube_cluster_name:%%%%tag_kube_cluster_name%%%%,kube_namespace:%s,kube_deployment:nginx}.rollup(60)
So, as it is today, the total number of TPS received by all Nginx pods it divided twice by the number of pods:
- Once on datadog backend side because of the
avg:operator in the metrics query. - Once by the HPA itself.
| Type: pulumi.String("AverageValue"), | |
| AverageValue: pulumi.String("10"), | |
| Type: pulumi.String("Value"), | |
| Value: pulumi.String("10"), |
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
In order to make the HPA more reactive, it could be nice disable the stabilization window as it is done in #721.
| }, | |
| Behavior: &autoscalingv2beta2.HorizontalPodAutoscalerBehaviorArgs{ | |
| ScaleDown: &autoscalingv2beta2.HPAScalingRulesArgs{ | |
| StabilizationWindowSeconds: pulumi.IntPtr(0), | |
| }, | |
| }, |
| Type: pulumi.String("AverageValue"), | ||
| AverageValue: pulumi.String("10"), |
There was a problem hiding this comment.
| Type: pulumi.String("AverageValue"), | |
| AverageValue: pulumi.String("10"), | |
| Type: pulumi.String("Value"), | |
| Value: pulumi.String("10"), |
| }, | ||
| }, | ||
| )), | ||
| }, |
There was a problem hiding this comment.
| }, | |
| Behavior: &autoscalingv2beta2.HorizontalPodAutoscalerBehaviorArgs{ | |
| ScaleDown: &autoscalingv2beta2.HPAScalingRulesArgs{ | |
| StabilizationWindowSeconds: pulumi.IntPtr(0), | |
| }, | |
| }, | |
| }, |
| Type: pulumi.String("AverageValue"), | ||
| AverageValue: pulumi.String("10"), |
There was a problem hiding this comment.
| Type: pulumi.String("AverageValue"), | |
| AverageValue: pulumi.String("10"), | |
| Type: pulumi.String("Value"), | |
| Value: pulumi.String("10"), |
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
| }, | |
| Behavior: &autoscalingv2beta2.HorizontalPodAutoscalerBehaviorArgs{ | |
| ScaleDown: &autoscalingv2beta2.HPAScalingRulesArgs{ | |
| StabilizationWindowSeconds: pulumi.IntPtr(0), | |
| }, | |
| }, | |
| }, |
| Type: pulumi.String("AverageValue"), | ||
| AverageValue: pulumi.String("10"), |
There was a problem hiding this comment.
| Type: pulumi.String("AverageValue"), | |
| AverageValue: pulumi.String("10"), | |
| Type: pulumi.String("Value"), | |
| Value: pulumi.String("10"), |
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
| }, | |
| Behavior: &autoscalingv2beta2.HorizontalPodAutoscalerBehaviorArgs{ | |
| ScaleDown: &autoscalingv2beta2.HPAScalingRulesArgs{ | |
| StabilizationWindowSeconds: pulumi.IntPtr(0), | |
| }, | |
| }, | |
| }, |
scenarios/aws/eks/run.go
Outdated
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Which error are we checking here ?
In case of non-nil error, shouldn’t have we returned earlier ?
There was a problem hiding this comment.
sorry i just forgot to remove this!
What does this PR do?
Add workloads for testing EKS fargate. These new apps make use of the agent sidecar auto-injection feature.
Which scenarios this will impact?
EKS FargateMotivation
Continue building out existing container-integrations e2e test suite.
Additional Notes
Preview:
Update:
[metrics]