upgrade(installer): Use pipeline OCI image at bootstrap #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
3 times, most recently
from
8ad9370
to
877ed31
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
from
877ed31
to
5604968
Compare
coignetp
approved these changes
Apr 22, 2024
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
2 times, most recently
from
2534fa4
to
9596bde
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
from
9596bde
to
6c9ab23
Compare
coignetp
approved these changes
Apr 26, 2024
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
from
55cee79
to
0011fe4
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/custom-installer-bootstrap-image
branch
from
0011fe4
to
5475e5d
Compare
arbll
reviewed
Apr 26, 2024
| @@ -111,6 +117,8 @@ elif [ "${OS}" = "RedHat" ]; then | |||
| $sudo_cmd sh -c "echo -e '[datadog]\nname = Datadog, Inc.\nbaseurl = https://${yum_url}/${yum_repo_version}/${ARCH}/\nenabled=1\ngpgcheck=1\nrepo_gpgcheck=1\npriority=1\ngpgkey=${gpgkeys}' > /etc/yum.repos.d/datadog.repo" | |||
| $sudo_cmd yum -y clean metadata | |||
| $sudo_cmd yum -y install datadog-installer | |||
| $sudo_cmd DD_INSTALLER_REGISTRY="${DD_INSTALLER_REGISTRY}" DD_INSTALLER_BOOTSTRAP_VERSION="${DD_INSTALLER_BOOTSTRAP_VERSION}" DD_INSTALLER_REGISTRY_AUTH="${DD_INSTALLER_REGISTRY_AUTH}" /opt/datadog-installer/bin/installer/installer bootstrap | |||
There was a problem hiding this comment.
Let's discuss before merging: I'm wondering if it's not better to keep this on the agent side especially with tests on the bootstrap process itself
There was a problem hiding this comment.
It should be here for individual VMs or the lab, but we could make it optional with a flag for the E2E.
KevinFairise2
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The installer installs its latest OCI version during postinst. We should use the one we just built in the pipeline. This is what this PR does: it uses what the agent CI pushes to the QA registries.
Requires DataDog/datadog-agent#24889 & DataDog/datadog-agent#25036
Which scenarios this will impact?
new-e2e-installer
Motivation
Additional Notes