Switch from using markdownlint-rule-titlecase in tests to markdownlin…

…t-rule-extended-ascii (0 dependencies), include new rule in Dockerfile-rules.
DavidAnson · May 15, 2024 · e5b85ff · e5b85ff
1 parent 626b637
commit e5b85ff
Show file tree

Hide file tree

Showing 17 changed files with 25 additions and 28 deletions.
diff --git a/docker/Dockerfile-rules b/docker/Dockerfile-rules
@@ -8,6 +8,7 @@ USER root
 RUN npm install --global --no-package-lock --production \
     @github/markdownlint-github \
     markdownlint-rule-enhanced-proper-names \
+    markdownlint-rule-extended-ascii \
     markdownlint-rule-github-admonition \
     markdownlint-rule-github-internal-links \
     markdownlint-rule-header-id \

diff --git a/package.json b/package.json
@@ -97,7 +97,7 @@
     "markdownlint-cli2-formatter-pretty": "0.0.5",
     "markdownlint-cli2-formatter-sarif": "0.0.1",
     "markdownlint-cli2-formatter-summarize": "0.0.6",
-    "markdownlint-rule-titlecase": "0.1.0",
+    "markdownlint-rule-extended-ascii": "0.1.0",
     "npm-run-all": "4.1.5"
   },
   "keywords": [

diff --git a/test/customRules/dir/subdir/.markdownlint-cli2.jsonc b/test/customRules/dir/subdir/.markdownlint-cli2.jsonc
@@ -3,6 +3,6 @@
     "../../rules/first-line.js",
     "../../node_modules/markdownlint-rule-sample-commonjs",
     "../../node_modules/markdownlint-rule-sample-module/sample-rule.mjs",
-    "markdownlint-rule-titlecase"
+    "markdownlint-rule-extended-ascii"
   ]
 }
diff --git a/test/customRules/dir/subdir/hr.md b/test/customRules/dir/subdir/hr.md
@@ -1,3 +1,3 @@
-# hr
+# HR ✅
 
 ---
diff --git a/test/formatter-pretty-appendLink/.markdownlint-cli2.jsonc b/test/formatter-pretty-appendLink/.markdownlint-cli2.jsonc
@@ -1,6 +1,6 @@
 {
   "customRules": [
-    "markdownlint-rule-titlecase"
+    "markdownlint-rule-extended-ascii"
   ],
   "outputFormatters": [
     [ "../../formatter-pretty", { "appendLink": true } ]

diff --git a/test/formatter-pretty-appendLink/viewme.md b/test/formatter-pretty-appendLink/viewme.md
@@ -1,4 +1,4 @@
-# title
+# Title ✅
 
 > Tagline 
 

diff --git a/test/markdownlint-cli2-jsonc-example/.markdownlint-cli2.jsonc b/test/markdownlint-cli2-jsonc-example/.markdownlint-cli2.jsonc
@@ -10,7 +10,7 @@
 
   // Include a custom rule package
   "customRules": [
-    "markdownlint-rule-titlecase"
+    "markdownlint-rule-extended-ascii"
   ],
 
   // Fix any fixable errors

diff --git a/test/markdownlint-cli2-jsonc-example/extended-ascii.md b/test/markdownlint-cli2-jsonc-example/extended-ascii.md
@@ -0,0 +1 @@
+# Title ✅
diff --git a/test/markdownlint-cli2-jsonc-example/title-case.md b/test/markdownlint-cli2-jsonc-example/title-case.md
diff --git a/test/markdownlint-cli2-yaml-example/.markdownlint-cli2.yaml b/test/markdownlint-cli2-yaml-example/.markdownlint-cli2.yaml
@@ -9,7 +9,7 @@ config:
 
 # Include a custom rule package
 customRules:
-  - markdownlint-rule-titlecase
+  - markdownlint-rule-extended-ascii
 
 # Fix any fixable errors
 fix: true

diff --git a/test/markdownlint-cli2-yaml-example/extended-ascii.md b/test/markdownlint-cli2-yaml-example/extended-ascii.md
@@ -0,0 +1 @@
+# Title ✅
diff --git a/test/markdownlint-cli2-yaml-example/title-case.md b/test/markdownlint-cli2-yaml-example/title-case.md
diff --git a/test/merge-options-test.js b/test/merge-options-test.js
@@ -30,7 +30,7 @@ test("full/empty", (t) => {
           "no-trailing-spaces": false,
           "no-multiple-blanks": false
         },
-        "customRules": [ "markdownlint-rule-titlecase" ],
+        "customRules": [ "markdownlint-rule-extended-ascii" ],
         "fix": true
       },
       {}
@@ -40,7 +40,7 @@ test("full/empty", (t) => {
         "no-trailing-spaces": false,
         "no-multiple-blanks": false
       },
-      "customRules": [ "markdownlint-rule-titlecase" ],
+      "customRules": [ "markdownlint-rule-extended-ascii" ],
       "fix": true
     }
   );
@@ -56,7 +56,7 @@ test("empty/full", (t) => {
           "no-trailing-spaces": false,
           "no-multiple-blanks": false
         },
-        "customRules": [ "markdownlint-rule-titlecase" ],
+        "customRules": [ "markdownlint-rule-extended-ascii" ],
         "fix": true
       }
     ),
@@ -65,7 +65,7 @@ test("empty/full", (t) => {
         "no-trailing-spaces": false,
         "no-multiple-blanks": false
       },
-      "customRules": [ "markdownlint-rule-titlecase" ],
+      "customRules": [ "markdownlint-rule-extended-ascii" ],
       "fix": true
     }
   );
@@ -79,7 +79,7 @@ test("partial/partial merge", (t) => {
         "config": {
           "no-trailing-spaces": false
         },
-        "customRules": [ "markdownlint-rule-titlecase" ]
+        "customRules": [ "markdownlint-rule-extended-ascii" ]
       },
       {
         "config": {
@@ -93,7 +93,7 @@ test("partial/partial merge", (t) => {
         "no-trailing-spaces": false,
         "no-multiple-blanks": false
       },
-      "customRules": [ "markdownlint-rule-titlecase" ],
+      "customRules": [ "markdownlint-rule-extended-ascii" ],
       "fix": true
     }
   );
@@ -116,7 +116,7 @@ test("full/full replace", (t) => {
           "no-trailing-spaces": false,
           "no-multiple-blanks": false
         },
-        "customRules": [ "markdownlint-rule-titlecase" ],
+        "customRules": [ "markdownlint-rule-extended-ascii" ],
         "fix": true
       }
     ),
@@ -125,7 +125,7 @@ test("full/full replace", (t) => {
         "no-trailing-spaces": false,
         "no-multiple-blanks": false
       },
-      "customRules": [ "markdownlint-rule-titlecase" ],
+      "customRules": [ "markdownlint-rule-extended-ascii" ],
       "fix": true
     }
   );

diff --git a/test/snapshots/markdownlint-cli2-test-exec.js.md b/test/snapshots/markdownlint-cli2-test-exec.js.md
@@ -1186,7 +1186,7 @@ Generated by [AVA](https://avajs.dev).
       formatterJson: '',
       formatterJunit: '',
       formatterSarif: '',
-      stderr: `title-case.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Heading, found # heading']␊
+      stderr: `extended-ascii.md:1:9 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       viewme.md:6 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Description"]␊
       `,
       stdout: '',
@@ -1243,7 +1243,7 @@ Generated by [AVA](https://avajs.dev).
       formatterJson: '',
       formatterJunit: '',
       formatterSarif: '',
-      stderr: `title-case.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Heading, found # heading']␊
+      stderr: `extended-ascii.md:1:9 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       viewme.md:6 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Description"]␊
       `,
       stdout: '',
@@ -2817,8 +2817,8 @@ Generated by [AVA](https://avajs.dev).
       dir/about.md:4 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "1. List"]␊
       dir/about.md:5:1 MD029/ol-prefix Ordered list item prefix [Expected: 2; Actual: 3; Style: 1/2/3]␊
       dir/about.md:6 every-n-lines Rule that reports an error every N lines [Line number 6]␊
+      dir/subdir/hr.md:1:6 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       dir/subdir/hr.md:1 first-line Rule that reports an error for the first line␊
-      dir/subdir/hr.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Hr, found # hr']␊
       dir/subdir/hr.md:3 sample-rule-commonjs Sample rule (commonjs) [Sample error for hr]␊
       dir/subdir/hr.md:3 sample-rule-module Sample rule (module) [Sample error for hr]␊
       dir/subdir/info.md:1 first-line Rule that reports an error for the first line␊
@@ -5866,7 +5866,7 @@ Generated by [AVA](https://avajs.dev).
       [35mdir/subdir/info.md[39m[36m:[39m[32m2[39m[36m:[39m[32m6[39m [90mMD038/no-space-in-code[39m Spaces inside code span elements[90m [Context: "\` code1\`"][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md038.md[39m␊
       [35mdir/subdir/info.md[39m[36m:[39m[32m2[39m[36m:[39m[32m20[39m [90mMD038/no-space-in-code[39m Spaces inside code span elements[90m [Context: "\`code2 \`"][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md038.md[39m␊
       [35mdir/subdir/info.md[39m[36m:[39m[32m4[39m [90mMD012/no-multiple-blanks[39m Multiple consecutive blank lines[90m [Expected: 1; Actual: 2][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md012.md[39m␊
-      [35mviewme.md[39m[36m:[39m[32m1[39m[36m:[39m[32m1[39m [90mtitlecase-rule[39m Titlecase rule[90m [Title Case: 'Expected # Title, found # title'][39m␊
+      [35mviewme.md[39m[36m:[39m[32m1[39m[36m:[39m[32m9[39m [90mextended-ascii[39m Only extended ASCII characters are allowed[90m [Blocked character: '✅'][39m␊
       [35mviewme.md[39m[36m:[39m[32m3[39m[36m:[39m[32m10[39m [90mMD009/no-trailing-spaces[39m Trailing spaces[90m [Expected: 0 or 2; Actual: 1][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md009.md[39m␊
       [35mviewme.md[39m[36m:[39m[32m5[39m [90mMD012/no-multiple-blanks[39m Multiple consecutive blank lines[90m [Expected: 1; Actual: 2][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md012.md[39m␊
       [35mviewme.md[39m[36m:[39m[32m6[39m [90mMD025/single-title/single-h1[39m Multiple top-level headings in the same document[90m [Context: "# Description"][39m[94m https://github.com/DavidAnson/markdownlint/blob/vX.Y.Z/doc/md025.md[39m␊

diff --git a/test/snapshots/markdownlint-cli2-test-exec.js.snap b/test/snapshots/markdownlint-cli2-test-exec.js.snap
diff --git a/test/snapshots/markdownlint-cli2-test-main.js.md b/test/snapshots/markdownlint-cli2-test-main.js.md
@@ -1186,7 +1186,7 @@ Generated by [AVA](https://avajs.dev).
       formatterJson: '',
       formatterJunit: '',
       formatterSarif: '',
-      stderr: `title-case.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Heading, found # heading']␊
+      stderr: `extended-ascii.md:1:9 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       viewme.md:6 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Description"]␊
       `,
       stdout: '',
@@ -1243,7 +1243,7 @@ Generated by [AVA](https://avajs.dev).
       formatterJson: '',
       formatterJunit: '',
       formatterSarif: '',
-      stderr: `title-case.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Heading, found # heading']␊
+      stderr: `extended-ascii.md:1:9 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       viewme.md:6 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Description"]␊
       `,
       stdout: '',
@@ -2817,8 +2817,8 @@ Generated by [AVA](https://avajs.dev).
       dir/about.md:4 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "1. List"]␊
       dir/about.md:5:1 MD029/ol-prefix Ordered list item prefix [Expected: 2; Actual: 3; Style: 1/2/3]␊
       dir/about.md:6 every-n-lines Rule that reports an error every N lines [Line number 6]␊
+      dir/subdir/hr.md:1:6 extended-ascii Only extended ASCII characters are allowed [Blocked character: '✅']␊
       dir/subdir/hr.md:1 first-line Rule that reports an error for the first line␊
-      dir/subdir/hr.md:1:1 titlecase-rule Titlecase rule [Title Case: 'Expected # Hr, found # hr']␊
       dir/subdir/hr.md:3 sample-rule-commonjs Sample rule (commonjs) [Sample error for hr]␊
       dir/subdir/hr.md:3 sample-rule-module Sample rule (module) [Sample error for hr]␊
       dir/subdir/info.md:1 first-line Rule that reports an error for the first line␊

diff --git a/test/snapshots/markdownlint-cli2-test-main.js.snap b/test/snapshots/markdownlint-cli2-test-main.js.snap