Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdownlint-cli2-formatter-pretty: Add support for configurable colors #321

Closed
ltickett opened this issue May 15, 2024 · 4 comments
Closed
Labels
question Further information is requested

Comments

@ltickett
Copy link

The default colors don't work too well in GitLab CI job logs https://gitlab.com/components/markdownlint/-/jobs/6830839750

image

Let's add support for configuring the colors using params.

@DavidAnson
Copy link
Owner

As I recall, I based the current colors on something popular (ESLint or npm, maybe?). Rather than add config for this, I'd prefer to use a single/fixed color palette that works well on light and dark backgrounds. Or else offer a light/dark configuration setting instead of exposing every single color choice.

Alternatively, maybe you don't need to colorize in the GitLab scenario?

@DavidAnson DavidAnson added the question Further information is requested label May 15, 2024
@ltickett
Copy link
Author

Thanks @DavidAnson I have essentially made a copy of the formatter for now and implemented this locally for now. We do think the color helps to differentiate each part of the message.

I threw up a pull request (didn't expect such a quick response :)

I would consider a simpler approach, maybe just fixing the one color that doesn't currently render well, or offering "2 options".

DavidAnson added a commit that referenced this issue May 20, 2024
…nd details/context for better visual contrast (fixes #321).
@DavidAnson
Copy link
Owner

markdownlint-cli2-formatter-pretty version 0.0.6 uses yellow instead of gray for better contrast.

@ltickett
Copy link
Author

Super- thanks for tweaking this @DavidAnson 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants