-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdownlint-cli2-formatter-pretty: Add support for configurable colors #321
Comments
As I recall, I based the current colors on something popular (ESLint or npm, maybe?). Rather than add config for this, I'd prefer to use a single/fixed color palette that works well on light and dark backgrounds. Or else offer a light/dark configuration setting instead of exposing every single color choice. Alternatively, maybe you don't need to colorize in the GitLab scenario? |
Thanks @DavidAnson I have essentially made a copy of the formatter for now and implemented this locally for now. We do think the color helps to differentiate each part of the message. I threw up a pull request (didn't expect such a quick response :) I would consider a simpler approach, maybe just fixing the one color that doesn't currently render well, or offering "2 options". |
…nd details/context for better visual contrast (fixes #321).
|
Super- thanks for tweaking this @DavidAnson 🙏 |
The default colors don't work too well in GitLab CI job logs https://gitlab.com/components/markdownlint/-/jobs/6830839750
Let's add support for configuring the colors using params.
The text was updated successfully, but these errors were encountered: