Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter pretty colors param #322

Closed

Conversation

ltickett
Copy link

Adds support for custom colors in the formatter-pretty plugin.

Closes: #321

@ltickett ltickett changed the base branch from main to next May 15, 2024 07:22
@ltickett
Copy link
Author

I couldn't find any tests for the current formatter to be able to add tests for my changes.

@DavidAnson
Copy link
Owner

Thanks! Tests run as part of the base project. The scripts "ci" and "update-snapshots" will be helpful here.

Regarding the change itself, as discussed in the issue, I would much prefer an approach that tweaks the single problematic color. It sounds like you think that is possible. What's done here is definitely more flexible, but commits to all of those specific fields and adds a many opportunities for the code to crash if someone doesn't know what colors are valid or misspells one. It converts this fairly safe and easy formatter into something potentially difficult to use.

@ltickett ltickett closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdownlint-cli2-formatter-pretty: Add support for configurable colors
2 participants