Upgrade add-on to Ember.js v5.8.1

[MrChocolatine]

Breaking

Upgrade add-on to ember-cli v5.8.1 (#190)

The new requirements are:

• Ember.js v4.12 or above
• Ember CLI v4.12 or above
• Node.js v18 or above

---

Resolves #172 .

Closes #171 .
Closes #174 .
Closes #187 .
Closes #188 .
Closes #189 .

[BlueCutOfficial]

Why this change? I am not aware of a <h1> already present in the page 🤔

[MrChocolatine]

Also coming from the blueprint:
https://github.com/ember-cli/ember-addon-output/blob/v5.8.1/tests/dummy/app/templates/application.hbs

More in sync with what's natively generated.

[BlueCutOfficial]

It seems to be a very very old line, so I am not sure it's intended. I've checked our dummy app and we don't have any <h1> title, so our current code is slightly better in terms of DOM structure.

[MrChocolatine]

Sorry I don't get what you mean. I am trying to understand.

Right now we have this:

ember-reading-time/tests/dummy/app/templates/application.hbs

Line 3 in d5e881d

<h1>Welcome to ember-reading-time</h1>

and the blueprint applies this:

https://github.com/ember-cli/ember-addon-output/blob/v5.8.1/tests/dummy/app/templates/application.hbs#L3

Why not reusing what is generated by default?

[BlueCutOfficial]

My opinion is this change is unnecessary. There's no particular reason to replace our <h1> with a <h2>, it's just the main title of our page. I don't know why the blueprint has this content, but we have no reason to follow it here, this is our dummy app.

[MrChocolatine]

but we have no reason to follow it here

Just to ease the upgrades by having less code diff.

[MrChocolatine]

I will revert that change, that's fine it's not blocking at all.
It's just, in my mind, while I understand what you said, I don't get why we want to deviate from the blueprint with such an unneeded change. (and then deal with conflict/code diff when upgrading, like in this PR)