Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cargo.toml to root #2434

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Move cargo.toml to root #2434

wants to merge 10 commits into from

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Sep 10, 2023

Summary

  • Move cargo.toml to root
  • Cleanup rebuild on head change in rust build scripts
  • Move testdata into it's place
  • Correct analyzer defaults for vscode
  • Don't force SOLC_PATH requirement. It's prioritized, but will gracefully use path SOLC

Note: This is just another step in direction to make the build system more integrated.

Next step: Move rust to end of build process.

This PR makes it easier to run cargo directly if needed.

Eg: This allows

CARGO_TARGET_DIR=$(pwd)/build/target cargo build

or with in-built PROTOC and SOLC, pass them similarly or

export CARGO_TARGET_DIR=$(pwd)/build/target 
export SOLC_PATH=$(pwd)/build/depends/x86_64-pc-linux-gnu/bin/solc 
export PROTOC=$(pwd)/build/depends/x86_64-pc-linux-gnu/bin/protoc 

# Now can just run
cargo build

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants