Generalise dcs to work on other distros #25
Conversation
- Make dcs-unpack and computer-ranking accept a -dist parameter defaulting to
'sid'
- Search all components instead of just 'main'
|
Thanks for the PR, I will look at it carefully and merge it on Sunday once I get home, unless it’s particularly urgent for you :). |
|
OK. I think I forgot to mention or record in a separate commit that this changes dcs-unpack to use Directory: from the .dsc instead of constructing the path manually. I think it's nicer but didn't check on Debian if it works there (should do though from looking at some dsc files). |
|
Sorry that this is taking so long, but I’ve been swamped with emails and other work. I hope I can get to having a closer look at this PR in the next two or three days. |
| if _, err := os.Stat(oldPath); err == nil { | ||
| // Check whether the directory exists in the old "unpacked" | ||
| // directory and hardlink only if the new path doesn't exist | ||
| // (to avoid wasted time hardlinking in case of partial runs) |
There was a problem hiding this comment.
What I don’t like about this is that you need to cancel your runs on “directory boundaries”. I.e., if 3 of 5 files are unpacked, you cancel, the next run will skip the directory even though 2 files are still missing.
Handling this case properly is too complex, so that the entire optimization is not worth it. Can you remove it?
|
In addition to the inline comments, I would appreciate it if you could do the refactoring in separate commits, so that it becomes clearer what you do :). |
| "strings" | ||
| ) | ||
|
|
||
| var mirrorPath = flag.String("mirror_path", | ||
| "/media/sdd1/debian-source-mirror/", | ||
| "Path to the debian source mirror (which contains the 'dists' and 'pool' folder)") | ||
| var dist = flag.String("dist", | ||
| "sid", | ||
| "The release to scan") |
There was a problem hiding this comment.
Instead of “release”, use “distribution” to stay consistent with the naming throughout DCS.
|
I'll try and get to this soon. Sorry for blocking. |
No description provided.