Check if name or email are present on global level before adding to git locally #106
Conversation
…obal or system level
| var stdout bytes.Buffer | ||
| cmd := exec.Command("git", gitArgs...) | ||
| cmd.Stdout = &stdout | ||
| cmd.Stderr = ioutil.Discard |
There was a problem hiding this comment.
This seems redundant — not setting cmd.Stderr has the same effect, no?
| gitArgs := append([]string{"config", "--get", "--null"}, args...) | ||
| var stdout bytes.Buffer | ||
| cmd := exec.Command("git", gitArgs...) | ||
| cmd.Stdout = &stdout |
There was a problem hiding this comment.
Instead of dealing with the buffer manually, use cmd.Output() instead of cmd.Run() below.
| if exitError, ok := err.(*exec.ExitError); ok { | ||
| if waitStatus, ok := exitError.Sys().(syscall.WaitStatus); ok { | ||
| if waitStatus.ExitStatus() == 1 { | ||
| return "", &ErrNotFound{Key: args[len(args)-1]} |
There was a problem hiding this comment.
We don’t have the ErrNotFound type, so just return err here
| @@ -279,6 +279,26 @@ func runGitCommandIn(dir string, arg ...string) error { | |||
| return cmd.Run() | |||
| } | |||
|
|
|||
| func execGitConfig(args ...string) (string, error) { | |||
| gitArgs := append([]string{"config", "--get", "--null"}, args...) | |||
There was a problem hiding this comment.
Can you add a comment as to why --null is required here?
There was a problem hiding this comment.
Yes, I will. Per git-config manpage, it "allows for secure parsing of the output without getting confused e.g. by values that contain line breaks." Thank you!
|
I think adding the name and email at the local level is a good thing, so I have reservations about merging this PR. What does everyone else think? |
|
@anthonyfok Hi, do you really do that for any of your other Git repos? What if your email address changes? |
anthonyfok
force-pushed
the
master
branch
2 times, most recently
from
f0abee6
to
989837a
Compare
Untested, but is it approximately what you had in mind? Thank you!