Add support for recursive dep graph #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajudev can you review, or assign it to the maintainer for the review. For some reason Github don't show me that option anymore. |
|
Hi @anthonyfok, |
zhsj
reviewed
Mar 8, 2020
| fmt.Printf("Fetching dependencies of %s | It may take a while.\n\n", aurora.Bold(aurora.BrightBlue(importpath))) | ||
|
|
||
| // List | Graph | Tree | ||
| m, err := gocheckdeb.GetDep(importpath, "imports", formatType) |
There was a problem hiding this comment.
I'm not a fan of using many third-party libraries. Especially this library has some overlap functions with dh-make-golang.
zhsj
reviewed
Mar 8, 2020
| @@ -12,6 +12,8 @@ import ( | |||
| "sort" | |||
| "strings" | |||
|
|
|||
| "github.com/logrusorgru/aurora" | |||
There was a problem hiding this comment.
this library is not packaged in debian too. it's not so important to have colorful output...
There was a problem hiding this comment.
Update: golang-github-logrusorgru-aurora-dev
entered Debian on 2020-07-10
anthonyfok
reviewed
Aug 26, 2021
| @@ -12,6 +12,8 @@ import ( | |||
| "sort" | |||
| "strings" | |||
|
|
|||
| "github.com/logrusorgru/aurora" | |||
| "github.com/ramantehlan/GoCheckDeb/pkg/gocheckdeb" | |||
There was a problem hiding this comment.
Looks like we need to get github.com/ramantehlan/GoCheckDeb packaged for Debian first. 🤔
anthonyfok
force-pushed
the
master
branch
2 times, most recently
from
f0abee6
to
989837a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address Issue #89 and to add support to check recursively if the project and test dependencies are packaged for Debian or not.
-rsub-flag to currentestimateflag, which will be separate from plain estimate command.-formatsub-flag, to supports three output formats ("Graph", "Map", "List")Usage
I have also created a standalone tool for it, which you can check out here.