Skip to content

Commit

Permalink
Made submit() return a promise for async validation to fix issue [f…
Browse files Browse the repository at this point in the history
  • Loading branch information
Deckstar committed Nov 17, 2023
1 parent 1681f41 commit 2c4df27
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/final-form/src/FinalForm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1311,13 +1311,13 @@ function createForm<FormValues extends FormValuesShape = FormValuesShape>(
const asyncValidationPromisesKeys = Object.keys(asyncValidationPromises);
if (asyncValidationPromisesKeys.length) {
// still waiting on async validation to complete...
Promise.all(
const submissionPromise = Promise.all(
asyncValidationPromisesKeys.map(
(key) => asyncValidationPromises[Number(key)],
),
// eslint-disable-next-line no-console
).then(api.submit, console.error);
return;
).then(api.submit, console.error) as Promise<ValidationErrorsShape>;
return submissionPromise;
}
const submitIsBlocked = beforeSubmit();
if (submitIsBlocked) {
Expand Down

0 comments on commit 2c4df27

Please sign in to comment.