🤖 Merge PR #64300 fix(image-blob-reduce): correct type for init optio…

…ns by @hazolsky
DefinitelyTyped · Feb 10, 2023 · 0eee833 · 0eee833
1 parent c21b9f6
commit 0eee833
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/types/image-blob-reduce/image-blob-reduce-tests.ts b/types/image-blob-reduce/image-blob-reduce-tests.ts
@@ -1,10 +1,22 @@
-import * as pica from 'pica';
 import * as imageBlobReduce from 'image-blob-reduce';
 
+// no options
+// $ExpectType ImageBlobReduce
+imageBlobReduce();
+
+// $ExpectType Pica
+imageBlobReduce.pica();
+
+// with incorrect options
+// @ts-expect-error
+imageBlobReduce({ pica: imageBlobReduce.pica });
+
+// with options
 const createOptions: imageBlobReduce.Options = {
-    pica,
+    pica: imageBlobReduce.pica(),
 };
 
+// $ExpectType ImageBlobReduce
 const imageReducer = imageBlobReduce(createOptions);
 
 imageReducer.use(

diff --git a/types/image-blob-reduce/index.d.ts b/types/image-blob-reduce/index.d.ts
@@ -3,7 +3,7 @@
 // Definitions by: Matthias Fischer <https://github.com/dotnetautor>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
-import type { PicaStatic } from 'pica';
+import type { Pica, PicaStatic } from 'pica';
 
 interface InternalProperties {
     image: HTMLImageElement;
@@ -28,7 +28,7 @@ declare namespace imageBlobReduce {
     }
 
     interface Options {
-        pica?: PicaStatic;
+        pica?: Pica;
     }
 
     interface Env extends InternalProperties {
@@ -48,6 +48,7 @@ declare namespace imageBlobReduce {
     interface ImageBlobReduceStatic {
         new (options?: Options): ImageBlobReduce;
         (options?: Options): ImageBlobReduce;
+        pica: PicaStatic;
     }
 }