🤖 Merge PR #63882 [jest] type done callback on each by @staff0rd

* [jest] type done callback on each * additional test case * remove typing from array of arrays
DefinitelyTyped · Mar 15, 2023 · 6439217 · 6439217
1 parent d7dade7
commit 6439217
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/types/jest/index.d.ts b/types/jest/index.d.ts
@@ -486,15 +486,15 @@ declare namespace jest {
             timeout?: number,
         ) => void;
         // Not arrays.
-        <T>(cases: ReadonlyArray<T>): (name: string, fn: (...args: T[]) => any, timeout?: number) => void;
+        <T>(cases: ReadonlyArray<T>): (name: string, fn: (arg: T, done: DoneCallback) => any, timeout?: number) => void;
         (cases: ReadonlyArray<ReadonlyArray<any>>): (
             name: string,
             fn: (...args: any[]) => any,
             timeout?: number,
         ) => void;
         (strings: TemplateStringsArray, ...placeholders: any[]): (
             name: string,
-            fn: (arg: any) => any,
+            fn: (arg: any, done: DoneCallback) => any,
             timeout?: number,
         ) => void;
     }

diff --git a/types/jest/jest-tests.ts b/types/jest/jest-tests.ts
@@ -1675,6 +1675,17 @@ describe.each([
     });
 });
 
+// https://github.com/DefinitelyTyped/DefinitelyTyped/issues/34617
+
+it.each<number>([1, 2, 3])('dummy: %d', (num, done) => {
+    done();
+});
+
+const casesReadonlyArray = [[1, 2, 3] as ReadonlyArray<number>] as ReadonlyArray<ReadonlyArray<number>>;
+it.each(casesReadonlyArray)('%d', (a, b, c) => {
+    expect(a + b).toBe(c);
+});
+
 interface Case {
     a: number;
     b: number;
@@ -1686,9 +1697,10 @@ describe.each`
     ${1} | ${1} | ${2}
     ${1} | ${2} | ${3}
     ${2} | ${1} | ${3}
-`('$a + $b', ({ a, b, expected }: Case) => {
+`('$a + $b', ({ a, b, expected }: Case, done) => {
     test(`returns ${expected}`, () => {
         expect(a + b).toBe(expected);
+        done();
     });
 });
 
@@ -1754,6 +1766,16 @@ test.each([
     5000,
 );
 
+test.each([
+    [
+        { prop1: true, prop2: true },
+        { prop1: true, prop2: true },
+    ],
+    [{ prop1: true }, { prop1: true, prop2: false }],
+])('%j -> %j', (input, output) => {
+    console.log(input, output);
+});
+
 declare const constCases: [['a', 'b', 'ab'], ['d', 2, 'd2']];
 test.each(constCases)('%s + %s', (...args) => {
     // $ExpectType ["a", "b", "ab"] | ["d", 2, "d2"]