🤖 Merge PR #64311 [vuelidate] Fix max call stack size error in Vue 2.…

…7.6-14 by @IGx89 * [vuelidate] Fix max call stack size error in Vue 2.7.6-14 * Make minimum TS version 4.4 * Add tests * Tabs -> spaces in test file
DefinitelyTyped · Feb 13, 2023 · b09276c · b09276c
1 parent 131014c
commit b09276c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/types/vuelidate/index.d.ts b/types/vuelidate/index.d.ts
@@ -5,7 +5,7 @@
 //                 Orblazer <https://github.com/orblazer>
 //                 Yuri Krylov <https://github.com/shadrus>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// TypeScript Version: 2.4
+// TypeScript Version: 4.4
 
 import './vue'
 import './lib/validators'

diff --git a/types/vuelidate/vue.d.ts b/types/vuelidate/vue.d.ts
@@ -6,7 +6,7 @@ import { Validation } from './vuelidate'
 
 declare module 'vue/types/vue' {
     type ValidationProperties<V> = {
-        [P in Exclude<keyof V, '$v'>]?: Validation & ValidationProperties<V[P]> & ValidationEvaluation
+        [P in Exclude<keyof V, '$v' | '$parent' | '$root' | '$children'>]?: Validation & ValidationProperties<V[P]> & ValidationEvaluation
     }
 
     interface ValidationGroups {

diff --git a/types/vuelidate/vuelidate-tests.ts b/types/vuelidate/vuelidate-tests.ts
@@ -195,6 +195,16 @@ export class ValidComponent extends Vue {
             return !this.$v.password.minLength
         } else return false
     }
+
+    verifyNoTypeRecursion() {
+        const parent = this.$v.$parent;
+        const root = this.$v.$root;
+        const children = this.$v.$children;
+
+        parent // $ExpectType Vue<Record<string, any>, Record<string, any>, never, never, (event: string, ...args: any[]) => Vue<Record<string, any>, Record<string, any>, never, never, any>> | null
+        root // $ExpectType Vue<Record<string, any>, Record<string, any>, never, never, (event: string, ...args: any[]) => Vue<Record<string, any>, Record<string, any>, never, never, any>>
+        children // $ExpectType Vue<Record<string, any>, Record<string, any>, never, never, (event: string, ...args: any[]) => Vue<Record<string, any>, Record<string, any>, never, never, any>>[]
+    }
 }
 
 @Component({