🤖 Merge PR #44434 keccak: fix type definition by @odanado

DefinitelyTyped · May 4, 2020 · cdffe89 · cdffe89
1 parent 6de1126
commit cdffe89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/types/keccak/index.d.ts b/types/keccak/index.d.ts
@@ -15,13 +15,15 @@ export class Keccak extends Transform {
         options: TransformOptions,
     );
     update(data: string | Buffer, encoding?: BufferEncoding): Keccak;
-    digest(encoding?: BufferEncoding): Buffer;
+    digest(): Buffer;
+    digest(encoding: BufferEncoding): string;
 }
 
 export class Shake extends Transform {
     constructor(rate: number, capacity: number, delimitedSuffix: number | null, options: TransformOptions);
     update(data: string | Buffer, encoding?: BufferEncoding): Shake;
-    squeeze(dataByteLength: number, encoding?: BufferEncoding): Buffer;
+    squeeze(dataByteLength: number): Buffer;
+    squeeze(dataByteLength: number, encoding: BufferEncoding): string;
 }
 
 export type KeccakAlgorithm = 'keccak224' | 'keccak256' | 'keccak384' | 'keccak512';

diff --git a/types/keccak/keccak-tests.ts b/types/keccak/keccak-tests.ts
@@ -2,9 +2,12 @@ import create from 'keccak';
 
 const keccak = create('keccak224'); // $ExpectType Keccak
 keccak.update('alice').digest(); // $ExpectType Buffer
+keccak.update('alice').digest("hex"); // $ExpectType string
 
 const sha3 = create('sha3-224'); // $ExpectType Keccak
 sha3.update('alice').digest(); // $ExpectType Buffer
+sha3.update('alice').digest("utf-8"); // $ExpectType string
 
 const shake = create('shake128'); // $ExpectType Shake
 shake.update('alice').squeeze(42); // $ExpectType Buffer
+shake.update('alice').squeeze(42, "ascii"); // $ExpectType string