Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/react] csstype dependency not resolving #49713

Closed
5 tasks done
davidboschwitz opened this issue Nov 21, 2020 · 8 comments · Fixed by #49717
Closed
5 tasks done

[@types/react] csstype dependency not resolving #49713

davidboschwitz opened this issue Nov 21, 2020 · 8 comments · Fixed by #49717

Comments

@davidboschwitz
Copy link

davidboschwitz commented Nov 21, 2020

This is a ticket to track the @types/react side of frenic/csstype#119.

Copied from the above ticket:

Latest update (first seen today) seems to be breaking our build process. Please see below. I can attach debug logs if needed.

> node node_modules/typescript/bin/tsc

node_modules/@types/react/index.d.ts:38:22 - error TS2307: Cannot find module 'csstype' or its corresponding type declarations.

38 import * as CSS from 'csstype';
                        ~~~~~~~~~


Found 1 error.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! reaver.js.coreui@1.0.0 build:compile: `node node_modules/typescript/bin/tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the reaver.js.coreui@1.0.0 build:compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dbosch/.npm/_logs/2020-11-21T00_14_23_140Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! reaver.js.coreui@1.0.0 build: `npm run build:css && npm run build:compile && npm run build:copy`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the reaver.js.coreui@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dbosch/.npm/_logs/2020-11-21T00_14_23_179Z-debug.log

I have unblocked our build pipeline by manually adding "csstype": "3.0.2" as a dependency.

Thanks!

@davidboschwitz
Copy link
Author

Authors part III

@Jack-Works
@jablko
@magnetnation
@Igorbek
@ialexryan
@hankfanchiu
@guilhermehubner
@fregante
@gaspard
@frenic
@chabb
@vbfox
@ForbesLindesay
@foray1010
@Crashthatch
@alloy
@prigara
@dyst5422
@disjukr
@dimitropoulos
@dbismut
@davegregg
@devuxer
@dancerphil
@hellatan
@cynecx
@coreyward
@lemonmade
@cdeutsch
@bryanrsmith
@artem-malko
@armanio123
@newyankeecodeshop
@green-arrow
@amcasey
@kachkaev
@alexpyzhianov
@epzilla
@tony-scio
@magic-akari
@jessetrinity
@lwilkins

ps I feel like @-mentioning 142 authors is not worth any of our time.

@jakesylvestre
Copy link
Contributor

@davidboschwitz

Mention the authors (see Definitions by: in index.d.ts) so they can respond.

That means the people listed here:

image

Should be a lot less than 142

@davidboschwitz
Copy link
Author

Ah, thank you for clarifying that! Sorry everyone!

@viko16
Copy link

viko16 commented Nov 21, 2020

Seems that @types/react 16.14.* had remove csstype from dependencies ? Why? 😢

Diff
https://unpkg.com/browse/@types/react@16.14.1/package.json
https://unpkg.com/browse/@types/react@16.9.56/package.json

@eps1lon
Copy link
Collaborator

eps1lon commented Nov 21, 2020

Seems that @types/react 16.14.* had remove csstype from dependencies ? Why?

Diff
unpkg.com/browse/@types/react@16.14.1/package.json
unpkg.com/browse/@types/react@16.9.56/package.json

Looks like the types-publisher has a bug. The PR responsible for the broken release did not touch dependencies. Nope, definitely my mistake. Fix incoming. Sorry about that.

@pcorey
Copy link

pcorey commented Nov 21, 2020

Is this scheduled to go out in a patch release any time soon?

@eps1lon
Copy link
Collaborator

eps1lon commented Nov 22, 2020

Is this scheduled to go out in a patch release any time soon?

Subscribe to #49717 to be notified once it's released. A will comment with the newly created version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants