Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Add explicit dependency on csstype for v16 #49717

Merged
merged 1 commit into from Nov 21, 2020

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 21, 2020

Closes #49713

I forgot to move the package.json when creating v16 types in #48971.

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 21, 2020

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 49717,
  "author": "eps1lon",
  "headCommitAbbrOid": "0ed44b4",
  "headCommitOid": "0ed44b4ec50455bc83b6d5110b5bc151fc98034a",
  "stalenessInDays": 0,
  "lastPushDate": "2020-11-21T15:16:04.000Z",
  "lastCommentDate": "2020-11-21T16:18:32.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/v16/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "digiguru",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ferdaber",
      "date": "2020-11-21T19:29:46.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Nov 21, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Nov 21, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Nov 21, 2020
Copy link
Contributor

@ferdaber ferdaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the semver constraint be more lax to prevent accidental duplication?

@eps1lon
Copy link
Collaborator Author

eps1lon commented Nov 21, 2020

Should the semver constraint be more lax to prevent accidental duplication?

Just copied it from the current typings. I don't know if we're compatible with other major versions.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #49717 diff
Batch compilation
Memory usage (MiB) 130.8 127.4 -2.6%
Type count 34897 34897 0%
Assignability cache size 8284 8284 0%
Language service
Samples taken 2860 2860 0%
Identifiers in tests 2941 2941 0%
getCompletionsAtPosition
    Mean duration (ms) 256.7 255.8 -0.3%
    Mean CV 8.4% 8.5%
    Worst duration (ms) 1115.3 1078.0 -3.3%
    Worst identifier props x
getQuickInfoAtPosition
    Mean duration (ms) 255.8 254.5 -0.5%
    Mean CV 8.7% 8.5%
    Worst duration (ms) 887.2 781.5 -11.9%
    Worst identifier x ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Nov 21, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Nov 21, 2020
@johnnyreilly johnnyreilly merged commit 51511d0 into DefinitelyTyped:master Nov 21, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Nov 21, 2020
@eps1lon eps1lon deleted the fix/react/csstype branch November 22, 2020 11:12
@typescript-bot
Copy link
Contributor

I just published @types/react@16.14.2 to npm.

owenlow pushed a commit to owenlow/DefinitelyTyped that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@types/react] csstype dependency not resolving
4 participants