Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/istanbul-lib-coverage] Update typings #33646

Merged

Conversation

lorenzorapetti
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Migrate @jest/reporters to TypeScript jestjs/jest#7994
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 6, 2019
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Mar 6, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 6, 2019

@loryman Thank you for submitting this PR!

🔔 @jason0x43 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Mar 11, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Mar 11, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@weswigham weswigham merged commit 79863ec into DefinitelyTyped:master Mar 11, 2019
Pull Request Status Board automation moved this from Review to Done Mar 11, 2019
@typescript-bot
Copy link
Contributor

I just published @types/istanbul-lib-coverage@2.0.0 to npm.

@lorenzorapetti lorenzorapetti deleted the update-istanbul-lib-coverage branch March 12, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants