Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-transition-group] Support optional classNames prop on <CSSTransition/> #34462

Merged
merged 1 commit into from Apr 4, 2019
Merged

[react-transition-group] Support optional classNames prop on <CSSTransition/> #34462

merged 1 commit into from Apr 4, 2019

Conversation

ybiquitous
Copy link
Contributor

Since v2.8.0, classNames prop has been optional.

See also:

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Apr 4, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 4, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 4, 2019

@ybiquitous Thank you for submitting this PR!

🔔 @LKay @Epskampie - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit 117acdd into DefinitelyTyped:master Apr 4, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Apr 4, 2019
@typescript-bot
Copy link
Contributor

I just published @types/react-transition-group@2.8.0 to npm.

@ybiquitous ybiquitous deleted the react-transition-group/CSSTransition-classNames branch April 5, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants