feat(node): v12

[SimonSchick]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.0.0
• Increase the version number in the header if appropriate.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

[typescript-bot]

@SimonSchick Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

[typescript-bot]

@SimonSchick The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[SimonSchick]

@Flarna any breaking changes we want to make here? 😛

[Flarna]

@SimonSchick typings are not semver versions therefore I see no reason to sync breaking changes with node releases. In the end at most everything can be breaking...

[Flarna]

I think the changes for following PRs are missing here but they can be added also via separate PRs:
nodejs/node#19691
nodejs/node#26611
nodejs/node#26554
nodejs/node#26774
nodejs/node#26387

[SimonSchick]

I haven't seen those in the changelog, I'd be willing to amend those.

[SimonSchick]

@Flarna I skipped
nodejs/node#26554
nodejs/node#26774
for now, I cba to do this atm.

[typescript-bot]

@SimonSchick The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[SimonSchick]

@sandersn @rbuckton so either types-publisher is broken or the change related to esnext target in my PR causes it to break hardcore, please take a look.

[typescript-bot]

@SimonSchick Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@SimonSchick The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@SimonSchick The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[SimonSchick]

@rbuckton can you help out? I didn't even touch v7 typings and it's still erroring.

[sandersn]

@rbuckton and I looked at it, and it's a result of some new typings (simplecrawler) referring to ../node/v7/index.dts in the tsconfig instead of using <reference types="node/v7" /> in the source. It errored on checkin, but the PR run didn't catch it. I'm not sure why.

Anyway, it's fixed, and I re-ran all the failed builds.

[SimonSchick]

can you merge this then or do you want me to rebase?

[sandersn]

Well, now it's failing because of microsoft/TypeScript#31119 in nodal. I haven't had a chance to fix that one yet.

[sandersn]

OK, I cleaned up the current DT failures. After you merge from master, the build should be clean.

[typescript-bot]

I just published @types/node@12.0.0 to npm.