Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/pino] Document new config option #35757

Merged
merged 2 commits into from Jun 3, 2019

Conversation

kibertoad
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 27, 2019

@kibertoad Thank you for submitting this PR!

🔔 @psnider @BendingBender @screendriver @paambaati @alferpal @mortiy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Jun 1, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jun 1, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 1, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Copy link
Contributor

@screendriver screendriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Jun 1, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Jun 1, 2019
@amcasey amcasey merged commit 001ee99 into DefinitelyTyped:master Jun 3, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Jun 3, 2019
@kibertoad kibertoad deleted the pino-config branch June 3, 2019 23:41
@typescript-bot
Copy link
Contributor

I just published @types/pino@5.8.8 to npm.

iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
* Document new config option (implemented in pinojs/pino-pretty#67)

* Fix indentation to be consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants