Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ignoreOrder option to MiniCssExtractPlugin #37140

Merged
merged 3 commits into from Jul 26, 2019
Merged

Add the ignoreOrder option to MiniCssExtractPlugin #37140

merged 3 commits into from Jul 26, 2019

Conversation

skovy
Copy link
Contributor

@skovy skovy commented Jul 25, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37140 diff
Batch compilation
Memory usage (MiB) 68.4 65.9 -3.6%
Type count 10196 10199 0.0%
Assignability cache size 3046 3048 +0.1%
Subtype cache size 4 4 0.0%
Identity cache size 1 1 0.0%
Language service
Samples taken 41 47 +14.6%
Identifiers in tests 41 47 +14.6%
getCompletionsAtPosition
    Mean duration (ms) 373.9 366.5 -2.0%
    Median duration (ms) 381.9 366.5 -4.0%
    Mean CV 13.9% 16.2% +16.4%
    Worst duration (ms) 424.5 427.8 +0.8%
    Worst identifier filename filename
getQuickInfoAtPosition
    Mean duration (ms) 370.8 366.4 -1.2%
    Median duration (ms) 370.0 362.7 -2.0%
    Mean CV 15.4% 15.6% +1.5%
    Worst duration (ms) 438.6 431.0 -1.7%
    Worst identifier webpack MiniCssExtractPlugin

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jul 25, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jul 25, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 25, 2019

@skovy Thank you for submitting this PR!

🔔 @JounQin @dobogo - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jul 26, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jul 26, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@weswigham weswigham merged commit b12a305 into DefinitelyTyped:master Jul 26, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Jul 26, 2019
@typescript-bot
Copy link
Contributor

I just published @types/mini-css-extract-plugin@0.8.0 to npm.

@skovy skovy deleted the skovy/add-ignore-order-to-mini-css-extract-plugin branch July 29, 2019 23:57
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
…7140)

* Add the ignoreOrder option to MiniCssExtractPlugin

* Fix linting issues

* Update version number
breeze9527 pushed a commit to breeze9527/DefinitelyTyped that referenced this pull request Jan 27, 2020
…7140)

* Add the ignoreOrder option to MiniCssExtractPlugin

* Fix linting issues

* Update version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants