jest: Provides its own types #39666
jest: Provides its own types #39666
Conversation
There was a problem hiding this comment.
Jests' own typings are extremely lacking. in the Jest package it only has:
import * as cli from 'jest-cli';
export = cli;
And in jest-cli then: https://cdn.jsdelivr.net/npm/jest-cli@24.9.0/build/index.d.ts
As you can see these are only the cli typings and are far, far, faar from enough. Therefore @types/jest cannot be deprecated unless Facebook developers fix up their typings to include all the required data.
typescript-bot
added
Popular package
|
@a-tarasyuk Thank you for submitting this PR! 🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @favna @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@a-tarasyuk The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
There was a problem hiding this comment.
Jest codebase was indeed migrated to typescript, but this migration doesn't mean that it's ready to replace @types/jest. Consumers of Jest still need to use @types/jest at least for the time being.
Per jestjs/jest#7807
It is currently a non-goal to distribute TS types for using Jest - that is excellently handled in
@types/jestalready. At some point we might want to distribute that with jest as well - but that's a separate issue.
typescript-bot
added
the
Has Merge Conflict
|
@a-tarasyuk I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
This should be closed as per comments above. |
typescript-bot
added
the
Abandoned
|
@a-tarasyuk To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
And comment PR: This will deprecate
@types/jestin favor of justjest. CC @NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @JoshuaKGoldberg, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @favna, @gstamac, @ExE-Boss, @quassnoi, @Belco90WARNING: other packages depend on this!