Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): add errorOnUnmatchedPattern to CLIEngine Options #41889

Conversation

arthurdenner
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: New: Add no-error-on-unmatched-pattern flag (fixes #10587) eslint/eslint#12377
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jan 27, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jan 27, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 27, 2020

@arthurdenner Thank you for submitting this PR!

🔔 @pmdartus @j-f1 @saadq @JasonHK - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@arthurdenner arthurdenner force-pushed the feat/eslint-errorOnUnmatchedPattern branch from 1d6b942 to 88892ae Compare January 27, 2020 19:12
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #41889 diff
Batch compilation
Memory usage (MiB) 39.9 39.3 -1.4%
Type count 4354 4355 0%
Assignability cache size 1429 1430 0%
Language service
Samples taken 1490 1493 0%
Identifiers in tests 1490 1493 0%
getCompletionsAtPosition
    Mean duration (ms) 86.2 84.0 -2.5%
    Mean CV 15.1% 15.5%
    Worst duration (ms) 151.9 144.4 -4.9%
    Worst identifier line line
getQuickInfoAtPosition
    Mean duration (ms) 85.7 83.3 -2.8%
    Mean CV 15.0% 15.6% +3.7%
    Worst duration (ms) 152.1 139.9 -8.0%
    Worst identifier message code

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jan 27, 2020
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Feb 1, 2020
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Feb 1, 2020
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

Copy link
Contributor

@jessetrinity jessetrinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@typescript-bot typescript-bot moved this from Review to Waiting for Reviewers in Pull Request Status Board Feb 4, 2020
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. and removed Unmerged The author did not merge the PR when it was ready. labels Feb 4, 2020
@jessetrinity jessetrinity merged commit ff388a3 into DefinitelyTyped:master Feb 4, 2020
Pull Request Status Board automation moved this from Waiting for Reviewers to Done Feb 4, 2020
@arthurdenner arthurdenner deleted the feat/eslint-errorOnUnmatchedPattern branch February 4, 2020 17:45
@typescript-bot
Copy link
Contributor

I just published @types/eslint@6.1.8 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants