fix(fs-extra): missing createSymlink
#42385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed: - `createSymlink` - `createSymlinkSync` see: jprichardson/node-fs-extra#758 see: cucumber/cucumber-js#1286 Thanks!
typescript-bot
added
Popular package
|
@peterblazejewicz Thank you for submitting this PR! 🔔 @alan-agius4 @midknight41 @shiftkey @mees- @jrockwood @sangdth @ffflorian - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
ffflorian
approved these changes
Feb 15, 2020
typescript-bot
moved this from Waiting for Reviewers
to Check and Merge
in Pull Request Status Board
typescript-bot
added
Owner Approved
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
I just published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed:
createSymlinkcreateSymlinkSyncsee: jprichardson/node-fs-extra#758
see: cucumber/cucumber-js#1286
Thanks!
npm test.)npm run lint package-name(ortscif notslint.jsonis present).