New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react] Port ElementRef utility type from Flow #43201
Merged
orta
merged 10 commits into
DefinitelyTyped:master
from
alloy:react-add-element-ref-utility
Mar 20, 2020
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
de1592a
[react] Port ElementRef utility type from Flow
alloy d66bc4c
[react] Use least amount of required typing
alloy b92bf40
[react] Support forwarded refs with ElementRef
alloy 4e5d625
[react] Use correct function component return type
alloy 6b54006
[react] Add ElementRef test for memoized ref forwarding component
alloy 5fa3e17
[react] Add ElementRef test for lazy component
alloy 333a97a
[react] Match function components with props
alloy ce83070
[react] Fix test-case by moving type around
alloy 31151a2
[react] Fix flaky test-case
alloy bce5bbc
[recharts] Remove deprecated CSS properties
alloy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about for readability:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t want to add intermediate types into this namespace, but if people agree then I’m definitely not against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already exists
JSXElementConstructor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it, but didn’t feel like readability improved by using a type alias in this first part but then use different types below. I think if there were very narrowly defined type aliases for these then that might be helpful, but that would introduce types that don’t exist upstream and so I’d like an emphatic “yes please” before I do that.