update(puppeteer): product option support

[peterblazejewicz]

• product option support as per 2.1
• version bump
• test updated

https://github.com/puppeteer/puppeteer/releases/tag/v2.1.0
puppeteer/puppeteer#5137

Thanks!

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Run npm run lint package-name (or tsc if no tslint.json is present).
• Provide a URL to documentation or source code which provides context for the suggested changes
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@peterblazejewicz Thank you for submitting this PR!

🔔 @marvinhagemeister @cdeutsch @ksm2 @SimonSchick @serbanghita @JasonKaz @davecardwell @angrykoala - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

[SimonSchick]

Please move this to a union string. eg. ProductType = 'chrome' | 'firefox';

[peterblazejewicz]

@SimonSchick
Done, amended!

[typescript-bot]

@peterblazejewicz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

[typescript-bot]

🔔 @SimonSchick - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

[typescript-bot]

@peterblazejewicz Thank you for submitting this PR!

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 43716,
  "author": "peterblazejewicz",
  "owners": [
    "marvinhagemeister",
    "cdeutsch",
    "ksm2",
    "SimonSchick",
    "SerbanGhita",
    "JasonKaz",
    "davecardwell",
    "angrykoala"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "716f774",
  "headCommitOid": "716f774e60db972586897df9b6ae51409d954300",
  "mergeIsRequested": true,
  "stalenessInDays": 12,
  "lastCommitDate": "2020-04-29T20:22:27.000Z",
  "lastCommentDate": "2020-05-11T21:02:52.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43716/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "puppeteer"
  ],
  "files": [
    {
      "filePath": "types/puppeteer/index.d.ts",
      "kind": "definition",
      "package": "puppeteer"
    },
    {
      "filePath": "types/puppeteer/puppeteer-tests.ts",
      "kind": "test",
      "package": "puppeteer"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-11T20:56:56.000Z",
  "reviewersWithStaleReviews": [
    {
      "reviewedAbbrOid": "4d4ca94",
      "reviewer": "SimonSchick"
    }
  ],
  "approvalFlags": 4,
  "isChangesRequested": false
}

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#43716	diff
Batch compilation
Memory usage (MiB)	108.2	108.4	+0.1%
Type count	19393	19407	0%
Assignability cache size	38361	38364	0%
Language service
Samples taken	1180	1199	+2%
Identifiers in tests	1180	1199	+2%
getCompletionsAtPosition
Mean duration (ms)	609.6	612.8	+0.5%
Mean CV	8.7%	8.8%
Worst duration (ms)	869.7	775.1	-10.9%
Worst identifier	j	includes
getQuickInfoAtPosition
Mean duration (ms)	601.2	603.7	+0.4%
Mean CV	8.5%	8.3%	-2.4%
Worst duration (ms)	890.9	796.4	-10.6%
Worst identifier	jsonValue	rev

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

🔔 @marvinhagemeister @cdeutsch @ksm2 @SimonSchick @serbanghita @JasonKaz @davecardwell @angrykoala - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[peterblazejewicz]

Ready to merge

[typescript-bot]

I just published @types/puppeteer@2.1.0 to npm.