Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tape] Update types to 4.13.2 #43984

Merged
merged 1 commit into from Apr 17, 2020

Conversation

relaxolotl
Copy link
Contributor

@relaxolotl relaxolotl commented Apr 17, 2020

  • Definitions created and updated for extra skip and todo opts that can be passed to assert functions, e.g.
    • test.ok(true, "msg", { skip: [true|"reason for skipping"] })
    • test.ok(true, "msg", { todo: [true|"work in progress"] })
  • todo has been added to TestOptions.
  • Definition created for onFailure() handler.
  • Definitions created for match() and doesNotMatch() assertions
  • Comments have been updated to reflect phrasing used in tape's README.

Missing:

  • getHarness(opts). autoclose and exit options in getHarness.
  • opts in createHarness(opts). autoclose and exit options in createHarness.
  • exit in TestOptions.
  • test.close().

I've been unsuccessful in finding good documentation or tests for everything in the missing section, so I've left them out to avoid writing any incorrect definitions. I also ran this through prettier, hence the large number of formatting changes in this diff.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:
If changing an existing definition:

* Definitions created and updated for extra skip and todo opts that can be passed to assert functions.
* todo has been added to TestOptions.
* Definition created for onFailure() handler.
* Definitions created for match() and doesNotMatch() assertions
* Comments have been updated to reflect phrasing used in tape's README.

Missing:
* getHarness(opts). autoclose and exit options in getHarness.
* opts in createHarness(opts). autoclose and exit options in createHarness.
* exit in TestOptions.
* test.close().
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Apr 17, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 17, 2020

@relaxolotl Thank you for submitting this PR!

🔔 @Bartvds @sodatea @DennisSchwartz @mikehenrty @rostrowski @ljharb - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #43984 diff
Batch compilation
Memory usage (MiB) 69.6 69.6 0.0%
Type count 8434 8440 0%
Assignability cache size 859 860 0%
Language service
Samples taken 542 849 +57%
Identifiers in tests 542 849 +57%
getCompletionsAtPosition
    Mean duration (ms) 271.0 269.4 -0.6%
    Mean CV 10.3% 9.9%
    Worst duration (ms) 366.4 336.4 -8.2%
    Worst identifier test doesNotMatch
getQuickInfoAtPosition
    Mean duration (ms) 269.1 270.1 +0.4%
    Mean CV 10.6% 11.0% +3.8%
    Worst duration (ms) 341.7 342.4 +0.2%
    Worst identifier test notOk

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Apr 17, 2020
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems accurate, modulo the missing parts

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Apr 17, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 17, 2020
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123 armanio123 merged commit 753525d into DefinitelyTyped:master Apr 17, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants