New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tape] Update types to 4.13.2 #43984
Conversation
* Definitions created and updated for extra skip and todo opts that can be passed to assert functions. * todo has been added to TestOptions. * Definition created for onFailure() handler. * Definitions created for match() and doesNotMatch() assertions * Comments have been updated to reflect phrasing used in tape's README. Missing: * getHarness(opts). autoclose and exit options in getHarness. * opts in createHarness(opts). autoclose and exit options in createHarness. * exit in TestOptions. * test.close().
@relaxolotl Thank you for submitting this PR! 🔔 @Bartvds @sodatea @DennisSchwartz @mikehenrty @rostrowski @ljharb - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems accurate, modulo the missing parts
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
skip
andtodo
opts that can be passed to assert functions, e.g.test.ok(true, "msg", { skip: [true|"reason for skipping"] })
test.ok(true, "msg", { todo: [true|"work in progress"] })
Missing:
I've been unsuccessful in finding good documentation or tests for everything in the missing section, so I've left them out to avoid writing any incorrect definitions. I also ran this through prettier, hence the large number of formatting changes in this diff.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
bool | string
) option passed to asserts [Feat] Add descriptive messages for skipped asserts tape-testing/tape#476bool | string
) option passed to asserts Implements TAP TODO directive tape-testing/tape#254tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.