@types/chart.js - add number array chart data type

[awilson9]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: Add support for floating bar chart ([start, end]) chartjs/Chart.js#6056
• [N/A] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• [N/A ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[awilson9]

As per:
chartjs/Chart.js#6056
https://github.com/chartjs/Chart.js/releases/tag/v2.9.0

an array of numbers is a valid type for chart data. This enables support of floating bar charts.

[typescript-bot]

@awilson9 Thank you for submitting this PR!

🔔 @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @danmana @guillaume-ro-fr @archy-bold @braincore @frabnt @alexdor @mahnuh @Conrad777 @adripanico @wertzui @lekoaf @ElianCordoba @indigolain @Ricardo-Mello @rnicholus @mrjack88 @canoceto @nobu222 @Marcoru97 @tonybadguy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#44275	diff
Batch compilation
Memory usage (MiB)	83.6	82.8	-1.0%
Type count	11021	11045	0%
Assignability cache size	34718	34736	0%
Language service
Samples taken	816	854	+5%
Identifiers in tests	816	854	+5%
getCompletionsAtPosition
Mean duration (ms)	301.5	296.4	-1.7%
Mean CV	10.6%	11.2%
Worst duration (ms)	385.3	381.6	-1.0%
Worst identifier	options	doughnutChartModel
getQuickInfoAtPosition
Mean duration (ms)	303.5	297.6	-1.9%
Mean CV	10.7%	11.1%	+4.1%
Worst duration (ms)	422.1	390.5	-7.5%
Worst identifier	itemSort	usePointStyle

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@awilson9 Thank you for submitting this PR!

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

🔔 @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @danmana @guillaume-ro-fr @archy-bold @braincore @frabnt @alexdor @mahnuh @Conrad777 @adripanico @wertzui @lekoaf @ElianCordoba @indigolain @Ricardo-Mello @rnicholus @mrjack88 @canoceto @nobu222 @Marcoru97 @tonybadguy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 44275,
  "author": "awilson9",
  "owners": [
    "anuti",
    "FabienLavocat",
    "KentarouTakeda",
    "larrybahr",
    "mernen",
    "josefpaij",
    "danmana",
    "guillaume-ro-fr",
    "archy-bold",
    "braincore",
    "frabnt",
    "alexdor",
    "mahnuh",
    "Conrad777",
    "adripanico",
    "wertzui",
    "lekoaf",
    "ElianCordoba",
    "indigolain",
    "ricardo-mello",
    "rnicholus",
    "mrjack88",
    "canoceto",
    "nobu222",
    "Marcoru97",
    "tonybadguy"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "342a5c4",
  "headCommitOid": "342a5c4bd0c227bfcc576a94b4b907c7f91aec14",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-04-27T20:00:14.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44275/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "chart.js"
  ],
  "files": [
    {
      "filePath": "types/chart.js/chart.js-tests.ts",
      "kind": "test",
      "package": "chart.js"
    },
    {
      "filePath": "types/chart.js/index.d.ts",
      "kind": "definition",
      "package": "chart.js"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 1,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

@awilson9 Everything looks good here. Great job! I am ready to merge this PR on your behalf.
If you'd like that to happen, please post a comment with the exact text

Ready to merge

and I'll merge it the next time I look at this PR.

[awilson9]

Ready to merge

[typescript-bot]

I just published @types/chart.js@2.9.20 to npm.