New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix experimental react-dom apis with unstable #44598
Conversation
@raghav0622 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44598,
"author": "raghav0622",
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "9e42638",
"headCommitOid": "9e4263857af822957c79a0c5eb4790ab1c4a9c1f",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-09T15:06:58.000Z",
"lastCommentDate": "2020-05-09T19:31:42.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44598/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"react-dom"
],
"files": [
{
"filePath": "types/react-dom/experimental.d.ts",
"kind": "definition",
"package": "react-dom"
}
],
"hasDismissedReview": false,
"travisResult": "fail",
"travisUrl": "https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/685073497?utm_source=github_status&utm_medium=notification",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @MartynasZilinskas @theruther4d @Jessidhia - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
duplicate of #44564 |
#44564 (which is a superset of this PR) was merged |
Prefix experimental react-dom apis with unstable with refrence to https://github.com/DefinitelyTyped/DefinitelyTyped