New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest: add Date to setSystemTime param types #45685
Jest: add Date to setSystemTime param types #45685
Conversation
This reverts commit 725c00d.
@liamfd Thank you for submitting this PR! Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45685,
"author": "liamfd",
"owners": [
"NoHomey",
"jwbay",
"asvetliakov",
"alexjoverm",
"epicallan",
"ikatyang",
"wsmd",
"JamieMason",
"douglasduteil",
"ahnpnl",
"joshuakgoldberg",
"UselessPickles",
"r3nya",
"hotell",
"sebald",
"andys8",
"antoinebrault",
"gstamac",
"ExE-Boss",
"quassnoi",
"Belco90",
"tonyhallett",
"ycmjason",
"devanshj",
"pawfa",
"regevbr",
"mskelton"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "2023b2a",
"headCommitOid": "2023b2a00aa16f43d7d7f6cd44a33ae47a034cd1",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-06-24T12:37:41.000Z",
"lastCommentDate": "2020-06-24T12:37:41.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45685/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"jest"
],
"files": [
{
"filePath": "types/jest/index.d.ts",
"kind": "definition",
"package": "jest"
},
{
"filePath": "types/jest/jest-tests.ts",
"kind": "test",
"package": "jest"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-06-24T15:20:25.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @mskelton - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
@liamfd: I now remember that there was some talk about holding off this change, was it supposed to be merged? |
I just published |
@elibarzilay Hey, sorry, just seeing this. We pulled it out of #45496 (see #45496 (comment)) because at that time jestjs/jest#10169 hadn't been merged and released, but it has been now, so it seemed safe to add this. That said, I see that this got released as I'm happy to submit a PR to bump the version number in the header if that's beneficial. Sorry, I'm new to contributing to this repo. |
I think the version bump should be done as part of #45603. |
This reverts commit 725c00d.
Following up on #45496, this PR adds support for
Date
arguments tojest.setSystemTime
now that jestjs/jest#10169 is merged and released.Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
| Date
was added in setSystemTime and getRealSystemTime type and doc update jestjs/jest#1016916.0
, so it's pretty far out of date, but I can make the change if that's desirable)tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.