Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(react-helmet): 6.1 ES exports changes #46509

Merged

Conversation

peterblazejewicz
Copy link
Member

This commit updates definition by:

  • adding support for 6.1 change introducing named and default exports
    support (this fixes errorrs like JSX element type 'Helmet' does not have any construct or call signatures.
  • minor version bump
  • maintainer added

nfl/react-helmet#547
https://github.com/nfl/react-helmet/releases/tag/6.1.0

Thanks!

import Helmet from 'react-helmet';
import { default as Helmet } from 'react-helmet';
import { Helmet  } from 'react-helmet';
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes

This commit updates definition by:
- adding support for 6.1 change introducing named and default exports
  support (this fixes errorrs like ` JSX element type 'Helmet' does not
  have any construct or call signatures.`
- minor version bump
- maintainer added

nfl/react-helmet#547
https://github.com/nfl/react-helmet/releases/tag/6.1.0

Thanks!
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Aug 2, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 2, 2020

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 46509,
  "author": "peterblazejewicz",
  "owners": [
    "evanbb",
    "isman-usoh",
    "lith-light-g",
    "sammkj",
    "yuit",
    "ykzts",
    "wKovacs64",
    "Andriy2"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "e741fc3",
  "headCommitOid": "e741fc350de95d83b6f2e9d84ea51179bf3e44be",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-08-02T15:22:43.000Z",
  "lastCommentDate": "2020-08-03T19:10:42.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46509/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "react-helmet"
  ],
  "files": [
    {
      "path": "types/react-helmet/index.d.ts",
      "kind": "definition",
      "package": "react-helmet"
    },
    {
      "path": "types/react-helmet/react-helmet-tests.tsx",
      "kind": "test",
      "package": "react-helmet"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-08-02T21:48:02.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 2, 2020
@typescript-bot
Copy link
Contributor

🔔 @evanbb @isman-usoh @lith-light-g @sammkj @yuit @ykzts @wKovacs64 @andriy2 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #46509 diff
Batch compilation
Memory usage (MiB) 118.0 116.9 -0.9%
Type count 25345 25345 0%
Assignability cache size 6716 6716 0%
Language service
Samples taken 167 169 +1%
Identifiers in tests 167 169 +1%
getCompletionsAtPosition
    Mean duration (ms) 573.9 565.9 -1.4%
    Mean CV 8.7% 7.7%
    Worst duration (ms) 739.8 728.6 -1.5%
    Worst identifier html meta
getQuickInfoAtPosition
    Mean duration (ms) 549.8 545.4 -0.8%
    Mean CV 9.1% 8.7% -4.3%
    Worst duration (ms) 689.2 716.5 +4.0%
    Worst identifier hidden hidden

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Aug 2, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 2, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Aug 2, 2020
@typescript-bot
Copy link
Contributor

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@evanbb, @isman-usoh, @lith-light-g, @sammkj, @yuit, @ykzts, @wKovacs64, @andriy2: you can do this too.)

@peterblazejewicz
Copy link
Member Author

Ready to merge 🛴

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Aug 3, 2020
@typescript-bot typescript-bot merged commit 6e50238 into DefinitelyTyped:master Aug 3, 2020
@peterblazejewicz peterblazejewicz deleted the update/react-helmet branch August 3, 2020 19:11
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Aug 3, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
… changes by @peterblazejewicz

This commit updates definition by:
- adding support for 6.1 change introducing named and default exports
  support (this fixes errorrs like ` JSX element type 'Helmet' does not
  have any construct or call signatures.`
- minor version bump
- maintainer added

nfl/react-helmet#547
https://github.com/nfl/react-helmet/releases/tag/6.1.0

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants