update(terser-webpack-plugin): minimizerOptions option

[peterblazejewicz]

• minimizerOptions added
• test amended
• cleanup

webpack-contrib/terser-webpack-plugin#311

Thanks!

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Run npm run lint package-name (or tsc if no tslint.json is present).
• Provide a URL to documentation or source code which provides context for the suggested changes
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• terser-webpack-plugin on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 47518,
  "author": "peterblazejewicz",
  "owners": [
    "Danscho",
    "peterblazejewicz"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "f84ac1c",
  "headCommitOid": "f84ac1c637fe8578c5ea55c6b4bcdcc1658c5b91",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-11T21:01:50.000Z",
  "lastCommentDate": "2020-09-15T07:06:07.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47518/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "terser-webpack-plugin"
  ],
  "files": [
    {
      "path": "types/terser-webpack-plugin/index.d.ts",
      "kind": "definition",
      "package": "terser-webpack-plugin"
    },
    {
      "path": "types/terser-webpack-plugin/terser-webpack-plugin-tests.ts",
      "kind": "test",
      "package": "terser-webpack-plugin"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-09-15T07:04:44.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @Danscho — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

terser-webpack-plugin (unpkg)

was missing the following properties:

1. isSourceMap
2. buildError
3. isWebpack4
4. getAvailableNumberOfCores
5. getAsset

as well as these 2 other properties...

emitAsset, updateAsset

Generated by 🚫 dangerJS against f84ac1c

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#47518	diff
Batch compilation
Memory usage (MiB)	75.1	76.8	+2.2%
Type count	12168	12168	0%
Assignability cache size	2194	2195	0%
Language service
Samples taken	120	122	+2%
Identifiers in tests	120	122	+2%
getCompletionsAtPosition
Mean duration (ms)	389.2	384.7	-1.2%
Mean CV	9.4%	9.3%
Worst duration (ms)	462.6	494.7	+6.9%
Worst identifier	keep_fnames	TerserPlugin
getQuickInfoAtPosition
Mean duration (ms)	384.6	381.5	-0.8%
Mean CV	9.8%	9.5%	-2.6%
Worst duration (ms)	470.4	472.7	+0.5%
Worst identifier	condition	output

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Danscho: you can do this too.)

[Danscho]

Ready to merge