fix(frisby): remove unneeded reference to jest types

[G-Rath]

Found during #48473

Per my comment here:

It seems that the original reference was to jasmine, and was because it was argumenting the global jasmine namespace.

However, while v2 of @types/frisby removed this argumenting, the reference was kept in because the author wanted to have @types/jasmine pulled in because the library used jasmine?

I can understand why, and am not against it, but I think it would be better to remove this reference since frisby.js doesn't list jest as a dependency (not even as a peerDependency) nor does it require/import it anywhere, and because people using TypeScript will need to install @types/jest anyway as they'll be consuming them directly.

Additionally, the source code of frisby still references jasmine rather than jest, and was originally switched to jest as the jasmine types were causing problems (#32191).

[typescript-bot]

@G-Rath Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• frisby on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48935,
  "author": "G-Rath",
  "headCommitAbbrOid": "4c3aedd",
  "headCommitOid": "4c3aedd0913ea57b98c3ad7e33da052e7e09fdaf",
  "stalenessInDays": 31,
  "lastPushDate": "2020-10-20T07:11:16.000Z",
  "lastCommentDate": "2020-10-20T07:15:43.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "frisby",
      "kind": "edit",
      "files": [
        {
          "path": "types/frisby/frisby-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/frisby/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "cwoodland",
        "johnny4753"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @cwoodland @johnny4753 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@G-Rath The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

frisby (unpkg)

was missing the following properties:

1. delete

mongodb (unpkg)

was missing the following properties:

1. The declaration doesn't match the JavaScript module 'mongodb'. Reason:
   The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

Generated by 🚫 dangerJS against 4c3aedd

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

frisby/v*

Comparison details for frisby/* 📊

	master	#48935	diff
Batch compilation
Memory usage (MiB)	109.8	108.9	-0.8%
Type count	18720	17631	-6%
Assignability cache size	5292	5044	-5%
Language service
Samples taken	27	15	-44%
Identifiers in tests	27	15	-44%
getCompletionsAtPosition
Mean duration (ms)	718.1	685.9	-4.5%
Mean CV	9.5%	7.6%
Worst duration (ms)	806.7	769.0	-4.7%
Worst identifier	done	done
getQuickInfoAtPosition
Mean duration (ms)	695.9	704.3	+1.2%
Mean CV	9.1%	10.3%	+14.0%
Worst duration (ms)	745.1	772.9	+3.7%
Worst identifier	URL	frisby

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

mongodb/v*

Comparison details for mongodb/* 📊

	master	#48935	diff
Batch compilation
Memory usage (MiB)	87.7	84.7	-3.4%
Type count	16878	16758	-1%
Assignability cache size	4049	3868	-4%
Language service
Samples taken	1966	1970	0%
Identifiers in tests	2491	2347	-6%
getCompletionsAtPosition
Mean duration (ms)	423.5	419.8	-0.9%
Mean CV	6.6%	6.9%
Worst duration (ms)	576.6	561.7	-2.6%
Worst identifier	randomFiel2	stringField
getQuickInfoAtPosition
Mean duration (ms)	423.0	418.9	-1.0%
Mean CV	6.7%	6.8%	+1.6%
Worst duration (ms)	581.0	579.0	-0.3%
Worst identifier	ops	ok

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

I just published @types/frisby@2.0.9 to npm.