Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react(-dom): Update experimental typings #49152

Merged
merged 5 commits into from Oct 27, 2020

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 27, 2020

useOpaqueIdentifier was already added in #46692

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added Critical package Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. labels Oct 27, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 27, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 27, 2020

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 49152,
  "author": "eps1lon",
  "owners": [
    "MartynasZilinskas",
    "theruther4d",
    "Jessidhia",
    "johnnyreilly",
    "bbenezech",
    "pzavolinsky",
    "digiguru",
    "ericanderson",
    "DovydasNavickas",
    "guilhermehubner",
    "ferdaber",
    "jrakotoharisoa",
    "pascaloliv",
    "hotell",
    "franklixuefei",
    "saranshkataria",
    "lukyth",
    "eps1lon",
    "zieka",
    "dancerphil",
    "dimitropoulos",
    "disjukr",
    "vhfmag",
    "hellatan"
  ],
  "dangerLevel": "MultiplePackagesEdited",
  "headCommitAbbrOid": "1ecf471",
  "headCommitOid": "1ecf471c0d540059aeac0fde9d9ea6f5d8e117a1",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-27T15:40:52.000Z",
  "lastCommentDate": "2020-10-27T15:40:52.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49152/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "react-dom",
    "react"
  ],
  "files": [
    {
      "path": "types/react-dom/experimental.d.ts",
      "kind": "definition",
      "package": "react-dom"
    },
    {
      "path": "types/react-dom/test/experimental-tests.tsx",
      "kind": "test",
      "package": "react-dom"
    },
    {
      "path": "types/react/experimental.d.ts",
      "kind": "definition",
      "package": "react"
    },
    {
      "path": "types/react/test/experimental.tsx",
      "kind": "test",
      "package": "react"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 27, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

react-dom/v*

Comparison details for react-dom/* 📊
master #49152 diff
Batch compilation
Memory usage (MiB) 118.2 125.7 +6.4%
Type count 27087 27065 0%
Assignability cache size 6581 6578 0%
Language service
Samples taken 434 422 -3%
Identifiers in tests 434 422 -3%
getCompletionsAtPosition
    Mean duration (ms) 655.6 650.7 -0.8%
    Mean CV 8.0% 8.0%
    Worst duration (ms) 851.5 911.6 +7.1%
    Worst identifier fragment rootElement
getQuickInfoAtPosition
    Mean duration (ms) 655.0 654.5 -0.1%
    Mean CV 8.9% 8.9% +0.2%
    Worst duration (ms) 906.9 854.4 -5.8%
    Worst identifier renderIntoDocument createElement

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

react/v*

Comparison details for react/* 📊
master #49152 diff
Batch compilation
Memory usage (MiB) 129.0 121.4 -5.9%
Type count 34714 34722 0%
Assignability cache size 8145 8157 0%
Language service
Samples taken 2345 2345 0%
Identifiers in tests 2905 2921 +1%
getCompletionsAtPosition
    Mean duration (ms) 364.0 361.7 -0.6%
    Mean CV 8.0% 8.0%
    Worst duration (ms) 1364.3 1355.6 -0.6%
    Worst identifier props props
getQuickInfoAtPosition
    Mean duration (ms) 361.0 357.5 -1.0%
    Mean CV 7.9% 7.8% -0.6%
    Worst duration (ms) 1103.5 1068.8 -3.2%
    Worst identifier ref ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Oct 27, 2020
@johnnyreilly johnnyreilly merged commit a34a068 into DefinitelyTyped:master Oct 27, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Oct 27, 2020
@typescript-bot
Copy link
Contributor

I just published @types/react@16.9.54 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/react-dom@16.9.9 to npm.

@eps1lon eps1lon deleted the feat/react-experimental branch June 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Edits multiple packages Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants