Revert "Use NoticeMessage type for pg.Client 'notice' event."

[groner]

Reverts #51183, which has caused problems for multiple users using isolatedModules: true, due to the const enum in pg-protocol/lib/messages.

Hopefully this can be revisited in the future, if pg-protocol can be changed to expose the message interfaces without breaking isolated module builds.

#51183 (comment)
brianc/node-postgres#2473

[typescript-bot]

@groner Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• pg on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 13 days — please try to get reviewers!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51513,
  "author": "groner",
  "headCommitOid": "b478d10f85c4a38a44516fc98f04dc7783f74794",
  "lastPushDate": "2021-03-05T02:33:23.000Z",
  "lastActivityDate": "2021-03-18T18:19:01.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/pg/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/pg/pg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#51513	diff
Batch compilation
Memory usage (MiB)	79.2	71.1	-10.3%
Type count	10370	10257	-1%
Assignability cache size	1898	1885	-1%
Language service
Samples taken	525	514	-2%
Identifiers in tests	525	514	-2%
getCompletionsAtPosition
Mean duration (ms)	330.5	329.9	-0.2%
Mean CV	9.8%	10.1%
Worst duration (ms)	437.7	403.9	-7.7%
Worst identifier	catch	err
getQuickInfoAtPosition
Mean duration (ms)	338.4	338.8	+0.1%
Mean CV	9.1%	9.0%
Worst duration (ms)	405.9	432.2	+6.5%
Worst identifier	res	connectionTimeoutMillis

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@groner Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

Re-ping @pspeter3, @HoldYourWaffle:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[ujwal-setlur]

FYI, this issue has been fixed upstream: brianc/node-postgres#2490

[groner]

@ujwal-setlur thanks for the update. Hopefully a new pg release will follow soon. I'll close this for now.

[ujwal-setlur]

@groner I am not sure you should close this PR. The way it was fixed upstream may not be compatible with your previous PR. For example, MessageName.** will not work. You should look at brianc/node-postgres#2490. You may actually need to tweak this PR.